Bug 137836

Summary: Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, d-r, fmalita, gyuyoung.kim, kling, mmaxfield, pdr, rniwa, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-17 14:10:15 PDT
Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms(). This function is never called for SVG fonts so replace the if check by an assertion.
Attachments
Patch (2.07 KB, patch)
2014-10-17 14:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.98 KB, patch)
2014-10-17 14:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-17 14:13:22 PDT
Created attachment 240038 [details] Patch
Andreas Kling
Comment 2 2014-10-17 14:21:46 PDT
Comment on attachment 240038 [details] Patch r=me You could also mark applyTransforms() as deleted in SVGFontData. That way you'll get a compile error if you try to call it on an SVGFontData object.
Chris Dumez
Comment 3 2014-10-17 14:23:20 PDT
(In reply to comment #2) > Comment on attachment 240038 [details] > Patch > > r=me > > You could also mark applyTransforms() as deleted in SVGFontData. That way > you'll get a compile error if you try to call it on an SVGFontData object. Yes, love it
Chris Dumez
Comment 4 2014-10-17 14:42:37 PDT
Created attachment 240040 [details] Patch
WebKit Commit Bot
Comment 5 2014-10-17 16:59:11 PDT
Comment on attachment 240040 [details] Patch Clearing flags on attachment: 240040 Committed r174853: <http://trac.webkit.org/changeset/174853>
WebKit Commit Bot
Comment 6 2014-10-17 16:59:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.