Summary: | [Win] Allow WinLauncher to specify Custom User Agent strings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-10-17 12:32:12 PDT
Created attachment 240030 [details]
Patch
Comment on attachment 240030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240030&action=review > Tools/WinLauncher/Common.cpp:380 > + case IDM_UA_SAFARI_IOS_7_IPHONE: > + case IDM_UA_SAFARI_IOS_7_IPAD: Why not iOS 8? > Tools/WinLauncher/WinLauncher.cpp:409 > + case IDM_UA_SAFARI_IOS_7_IPHONE: > + customUserAgent = L"Mozilla/5.0 (iPod; CPU iPhone OS 6_1_3 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10B329 Safari/8536.25"; > + break; > + case IDM_UA_SAFARI_IOS_7_IPAD: > + customUserAgent = L"Mozilla/5.0 (iPad; CPU OS 6_1_3 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10B329 Safari/8536.25"; > + break; Please add iOS 8. > Tools/WinLauncher/WinLauncher.cpp:420 > + customUserAgent = L"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0<"; Is that supposed to have a "<" at the end? > Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:230 > +IDD_USER_AGENT DIALOGEX 0, 0, 309, 176 > +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "Dialog" > +FONT 8, "MS Shell Dlg", 400, 0, 0x1 > +BEGIN > + LTEXT "Type a custom user agent string for this page.",IDC_Message,7,7,295,19 > + EDITTEXT IDC_USER_AGENT_INPUT,7,34,295,117,ES_AUTOHSCROLL > + DEFPUSHBUTTON "OK",IDOK,198,155,50,14 > + PUSHBUTTON "Cancel",IDCANCEL,252,155,50,14 > +END This is cool! I didn't know you could do that. Committed r174831: <http://trac.webkit.org/changeset/174831> |