Bug 137822

Summary:

[GTK] Improve zooming gesture positioning

Product:

WebKit

Reporter:

Carlos Garnacho <carlosg>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137812

Bug Blocks:

Attachments:

Description	Flags
Patch to improve zooming gesture look&feel	cgarcia: review+, cgarcia: commit-queue-
Updated patch	none
Updated patch	none

Carlos Garnacho

Reported 2014-10-17 09:36:29 PDT

I'm attaching a patch, on top of bug #137812 , that fixes the zooming gesture positioning on 2-finger interaction with WebKitGTK+

Attachments
Patch to improve zooming gesture look&feel (8.40 KB, patch) 2014-10-17 09:38 PDT, Carlos Garnacho	cgarcia: review+ cgarcia: commit-queue-	Details Formatted Diff Diff
Updated patch (7.82 KB, patch) 2014-10-17 10:02 PDT, Carlos Garnacho	no flags	Details Formatted Diff Diff
Updated patch (7.89 KB, patch) 2014-10-17 10:08 PDT, Carlos Garnacho	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Carlos Garnacho

Comment 1 2014-10-17 09:38:54 PDT

Created attachment 240016 [details] Patch to improve zooming gesture look&feel

Carlos Garcia Campos

Comment 2 2014-10-17 09:47:42 PDT

Comment on attachment 240016 [details] Patch to improve zooming gesture look&feel View in context: https://bugs.webkit.org/attachment.cgi?id=240016&action=review This makes the zoom gesture work as expected, thanks! > Source/WebKit2/UIProcess/WebPageProxy.h:470 > + > + void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& center); > #endif I would use a separate block since this is for text composition stuff. > Source/WebKit2/UIProcess/gtk/GestureController.cpp:33 > +#include "WebPageMessages.h" You shouldn't need this. > Source/WebKit2/WebProcess/WebPage/WebPage.h:581 > + > + void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& result); > #endif Same here. > Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:313 > + > + GetCenterForZoomGesture(WebCore::IntPoint centerInViewCoordinates) -> (WebCore::IntPoint center) > #endif Ditto.

Carlos Garcia Campos

Comment 3 2014-10-17 09:52:46 PDT

Comment on attachment 240016 [details] Patch to improve zooming gesture look&feel View in context: https://bugs.webkit.org/attachment.cgi?id=240016&action=review >> Source/WebKit2/UIProcess/WebPageProxy.h:470 >> #endif > > I would use a separate block since this is for text composition stuff. The block should probably also include HAVE(GTK_GESTURES) since this is only used when GTK gestures are supported.

Carlos Garnacho

Comment 4 2014-10-17 10:02:58 PDT

Created attachment 240017 [details] Updated patch This updated patch applies all suggestions

Carlos Garnacho

Comment 5 2014-10-17 10:08:50 PDT

Created attachment 240019 [details] Updated patch Another update version, wrap the implementations in #if/#endif too

WebKit Commit Bot

Comment 6 2014-10-20 03:39:57 PDT

Comment on attachment 240019 [details] Updated patch Clearing flags on attachment: 240019 Committed r174882: <http://trac.webkit.org/changeset/174882>

WebKit Commit Bot

Comment 7 2014-10-20 03:40:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.