[GTK] Improve zooming gesture positioning

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garnacho]

I'm attaching a patch, on top of bug #137812 , that fixes the zooming gesture positioning on 2-finger interaction with WebKitGTK+

[Carlos Garnacho]

Created attachment 240016 [details]
Patch to improve zooming gesture look&feel

[Carlos Garcia Campos]

Comment on attachment 240016 [details]
Patch to improve zooming gesture look&feel

View in context: https://bugs.webkit.org/attachment.cgi?id=240016&action=review

This makes the zoom gesture work as expected, thanks!

> Source/WebKit2/UIProcess/WebPageProxy.h:470
> +
> +    void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& center);
>  #endif

I would use a separate block since this is for text composition stuff.

> Source/WebKit2/UIProcess/gtk/GestureController.cpp:33
> +#include "WebPageMessages.h"

You shouldn't need this.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:581
> +
> +    void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& result);
>  #endif

Same here.

> Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:313
> +
> +    GetCenterForZoomGesture(WebCore::IntPoint centerInViewCoordinates) -> (WebCore::IntPoint center)
>  #endif

Ditto.

[Carlos Garcia Campos]

Comment on attachment 240016 [details]
Patch to improve zooming gesture look&feel

View in context: https://bugs.webkit.org/attachment.cgi?id=240016&action=review

>> Source/WebKit2/UIProcess/WebPageProxy.h:470
>>  #endif
> 
> I would use a separate block since this is for text composition stuff.

The block should probably also include HAVE(GTK_GESTURES) since this is only used when GTK gestures are supported.

[Carlos Garnacho]

Created attachment 240017 [details]
Updated patch

This updated patch applies all suggestions

[Carlos Garnacho]

Created attachment 240019 [details]
Updated patch

Another update version, wrap the implementations in #if/#endif too

[WebKit Commit Bot]

Comment on attachment 240019 [details]
Updated patch

Clearing flags on attachment: 240019

Committed r174882: <http://trac.webkit.org/changeset/174882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.