Bug 137784
| Summary: | EWS incorrectly decides that patch fails to apply when Bugzilla gives an error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ddkilzer, jake.nielsen.webkit, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alexey Proskuryakov
In bug 137779, EWS failed to test a patch because Bugzilla was giving a 500 error. But the bot decided that the patch actually failed to apply:
Error: efl-wk2-ews unable to apply patch. 14 minutes ago
Patch does not apply [results]
Processing patch 239950 from bug 137779.
Traceback (most recent call last):
File "/home/buildbot/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
main()
File "/home/buildbot/WebKit/Tools/Scripts/webkit-patch", line 79, in main
WebKitPatch(os.path.abspath(__file__)).main()
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
result = command.check_arguments_and_execute(options, args, self)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 177, in execute
self._process_patch(patch, options, args, tool)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 203, in _process_patch
self._main_sequence.run_and_handle_errors(tool, options, state)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
self._run(tool, options, state)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
step(tool, options).run(state)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py", line 40, in run
ApplyPatch.run(self, state)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/tool/steps/applypatch.py", line 46, in run
self._tool.checkout().apply_patch(state["patch"])
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 163, in apply_patch
self._executive.run_command(args, input=patch.contents(), cwd=self._scm.checkout_root)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py", line 97, in contents
return self._bug._bugzilla.fetch_attachment_contents(self.id())
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 490, in fetch_attachment_contents
return self.browser.open(attachment_url).read()
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
return self._mech_open(url, data, timeout=timeout)
File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
This should be an easy fix, but difficult to test when Bugzilla is up and running.