Summary: | Various crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture is in progress | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, commit-queue, mitz, sam, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-10-15 22:42:34 PDT
Created attachment 239935 [details]
patch
Attachment 239935 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:241: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:246: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:43: _UIViewControllerOneToOneTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:44: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 239935 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239935&action=review > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:97 > + _backTransitionController = nullptr; > + _forwardTransitionController = nullptr; Isn’t nil more appropriate for these, since the underlying type is an id? I’m not convinced that we should clear these. Doing so doesn’t really guarantee anything except that if -directionForTransition: were to be called it would return the wrong answer. Comment on attachment 239935 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239935&action=review > Source/WebKit2/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + * UIProcess/ios/ViewGestureControllerIOS.mm: I would like to read a summary of the issue and how you fixed it here. (In reply to comment #3) > Comment on attachment 239935 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=239935&action=review > > > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:97 > > + _backTransitionController = nullptr; > > + _forwardTransitionController = nullptr; > > Isn’t nil more appropriate for these, since the underlying type is an id? > > I’m not convinced that we should clear these. Doing so doesn’t really > guarantee anything except that if -directionForTransition: were to be called > it would return the wrong answer. A valid point. This wasn't the key to the crash in the end, so I guess there's no point. We agree that the ViewGestureController pointer should be cleared, though? (In reply to comment #4) > Comment on attachment 239935 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=239935&action=review > > > Source/WebKit2/ChangeLog:9 > > + Reviewed by NOBODY (OOPS!). > > + > > + * UIProcess/ios/ViewGestureControllerIOS.mm: > > I would like to read a summary of the issue and how you fixed it here. There are four issues and four fixes, they're detailed individually below :D "this avoids"x3 + "null-check". But I will add a summary of some sort. |