Bug 137764

Summary: Use is<>() / downcast<>() for list-related render objects
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, mihnea
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137424    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-15 19:15:41 PDT
Use is<>() / downcast<>() for list-related render objects
Attachments
Patch (37.11 KB, patch)
2014-10-15 19:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (37.47 KB, patch)
2014-10-15 21:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-15 19:20:28 PDT
Created attachment 239917 [details] Patch
Benjamin Poulain
Comment 2 2014-10-15 21:17:48 PDT
Comment on attachment 239917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239917&action=review > Source/WebCore/html/HTMLLIElement.cpp:97 > while (!listNode) { This loop is so weird. I would prefer a while(true)+break or a do-while. > Source/WebCore/rendering/RenderListItem.cpp:155 > + Node* otherList = enclosingList(downcast<RenderListItem>(renderer)); Node->Element
Chris Dumez
Comment 3 2014-10-15 21:34:19 PDT
Created attachment 239927 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-15 23:04:38 PDT
Comment on attachment 239927 [details] Patch Clearing flags on attachment: 239927 Committed r174759: <http://trac.webkit.org/changeset/174759>
WebKit Commit Bot
Comment 5 2014-10-15 23:04:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.