| Summary: | [Mac] The first software paint of a <video> element takes up to 2.5s. | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||
| Status: | NEW --- | ||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, glenn, philipj, rniwa, sergio | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Jer Noble
2014-10-15 14:32:51 PDT
Created attachment 239896 [details]
Patch
Created attachment 239897 [details]
Patch
Comment on attachment 239897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239897&action=review Looks good to me! I think you misspelled "wait" as "whait" > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). I'm assuming there are no tests needed because this should have no visible change in behavior? > Source/WebCore/ChangeLog:21 > + whait when asked to paint with the video output. whait? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:-1997 > - NSDictionary* attributes = @{ (NSString*)kCVPixelBufferPixelFormatTypeKey: @(kCVPixelFormatType_422YpCbCr8) }; I assume the equivalent of this dictionary is created elsewhere when a new pixel format is actually needed? View in context: https://bugs.webkit.org/attachment.cgi?id=239897&action=review >> Source/WebCore/ChangeLog:6 >> + Reviewed by NOBODY (OOPS!). > > I'm assuming there are no tests needed because this should have no visible change in behavior? Yep. This is an optimization only. I'll add something to the ChangeLog to that effect. >> Source/WebCore/ChangeLog:21 >> + whait when asked to paint with the video output. > > whait? wait. >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:-1997 >> - NSDictionary* attributes = @{ (NSString*)kCVPixelBufferPixelFormatTypeKey: @(kCVPixelFormatType_422YpCbCr8) }; > > I assume the equivalent of this dictionary is created elsewhere when a new pixel format is actually needed? Nope. 'nil' means "Don't try to convert the CVPixelBuffer into a specific pixel format." So we want this to always be nil. Comment on attachment 239897 [details] Patch Attachment 239897 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5503095584849920 New failing tests: media/video-seek-past-end-paused.html Created attachment 239904 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 240153 [details]
Patch for landing
media/video-seek-past-end-paused.html is failing on WK2 Mavericks even without this patch. Created attachment 240385 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 240489 [details]
Patch for landing (rebaselined)
Created attachment 240504 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 240507 [details]
Patch for landing (>=Mavericks only)
Comment on attachment 240507 [details] Patch for landing (>=Mavericks only) Clearing flags on attachment: 240507 Committed r175251: <http://trac.webkit.org/changeset/175251> |