Bug 137750 – webkit-patch should include a test command that only runs RunTests

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Jake Nielsen]

Currently the build-and-test removes local changes, cleans, builds, and then runs tests. When making changes to RunTests, only the last step is of interest. It would be nice to have a command to run in that case.

[Jake Nielsen]

Created attachment 239888 [details]
Adds the test command

[Jake Nielsen]

bump

[Daniel Bates]

Comment on attachment 239888 [details]
Adds the test command

View in context: https://bugs.webkit.org/attachment.cgi?id=239888&action=review

> Tools/Scripts/webkitpy/tool/commands/download.py:99
> +class Test(AbstractSequencedCommand):
> +    name = "test"
> +    help_text = "Run the tests"
> +    steps = [
> +        steps.RunTests,
> +    ]
> +
> +    def _prepare_state(self, options, args, tool):
> +        options.test = True
> +

Notice that steps.RunTests runs test suites that depend on a built product (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we run such test suites?

[Jake Nielsen]

bump(In reply to comment #3)
> Comment on attachment 239888 [details]
> Adds the test command
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=239888&action=review
> 
> > Tools/Scripts/webkitpy/tool/commands/download.py:99
> > +class Test(AbstractSequencedCommand):
> > +    name = "test"
> > +    help_text = "Run the tests"
> > +    steps = [
> > +        steps.RunTests,
> > +    ]
> > +
> > +    def _prepare_state(self, options, args, tool):
> > +        options.test = True
> > +
> 
> Notice that steps.RunTests runs test suites that depend on a built product
> (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we
> run such test suites?

It assumes you've already built.

[Daniel Bates]

(In reply to comment #4)
> bump(In reply to comment #3)
> > Comment on attachment 239888 [details]
> > Adds the test command
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=239888&action=review
> > 
> > > Tools/Scripts/webkitpy/tool/commands/download.py:99
> > > +class Test(AbstractSequencedCommand):
> > > +    name = "test"
> > > +    help_text = "Run the tests"
> > > +    steps = [
> > > +        steps.RunTests,
> > > +    ]
> > > +
> > > +    def _prepare_state(self, options, args, tool):
> > > +        options.test = True
> > > +
> > 
> > Notice that steps.RunTests runs test suites that depend on a built product
> > (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we
> > run such test suites?
> 
> It assumes you've already built.

Can you elaborate? Specifically, are you referring to run-webkit-tests when you say "it"?

[Jake Nielsen]

(In reply to comment #5)
> (In reply to comment #4)
> > bump(In reply to comment #3)
> > > Comment on attachment 239888 [details]
> > > Adds the test command
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=239888&action=review
> > > 
> > > > Tools/Scripts/webkitpy/tool/commands/download.py:99
> > > > +class Test(AbstractSequencedCommand):
> > > > +    name = "test"
> > > > +    help_text = "Run the tests"
> > > > +    steps = [
> > > > +        steps.RunTests,
> > > > +    ]
> > > > +
> > > > +    def _prepare_state(self, options, args, tool):
> > > > +        options.test = True
> > > > +
> > > 
> > > Notice that steps.RunTests runs test suites that depend on a built product
> > > (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we
> > > run such test suites?
> > 
> > It assumes you've already built.
> 
> Can you elaborate? Specifically, are you referring to run-webkit-tests when
> you say "it"?

Oh, I meant the "test" command that got added to download.py by this patch.

[Jake Nielsen]

I stand corrected. This is equivalent to
./webkit-patch build-and-test --no-clean --no-update --test
so that's what I'll use.