Bug 137719

Summary: REGRESSION (r165356): Issues with Japanese text input
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=139459
Attachments:
Description Flags
proposed fix darin: review+

Alexey Proskuryakov
Reported 2014-10-14 14:41:09 PDT
This affects sync text input code path. 1. Kotoeri sometimes doesn't process the first keypress in a web page. 2. ATOK sometimes needs to consume a Return key, but it is passed down to a web page anyway (causing bad misbehavior on google.com). This happens because we EditorState is now tracked incorrectly. There is an async message sent with old state, and then a sync message response with new state. But these are delivered out of order, so UI process ends up with an incorrect idea about input state. Yes, the incorrect data has ignoreCompositionSelectionChange set on it, but that's not sufficient for UI side heuristics to work well. rdar://problem/18431952 rdar://problem/18483741
Attachments
proposed fix (2.22 KB, patch)
2014-10-14 14:56 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-10-14 14:56:33 PDT
Created attachment 239827 [details] proposed fix
Darin Adler
Comment 2 2014-10-14 15:44:31 PDT
Comment on attachment 239827 [details] proposed fix Any way to regression test this?
Alexey Proskuryakov
Comment 3 2014-10-14 16:27:00 PDT
It's likely technically possible to test with an API test, as these drive testing from UI process side, however the complexity of such a test scares. More importantly, an API test would only test sync API, which is on its way out. Committed <http://trac.webkit.org/r174708>.
Note You need to log in before you can comment on or make changes to this bug.