Bug 137714

Summary: Web Inspector: Add ESLint open source library to the inspector
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Jonathan Wells <jonowells>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] eslint addition.
timothy: review+, commit-queue: commit-queue-
[PATCH] eslint addition FIX.
none
[PATCH] eslint addition FIX and CHANGELOG.
none
[PATCH] eslint addition FIX and CHANGELOG. none

Description Jonathan Wells 2014-10-14 13:33:57 PDT 
Adding ESLint to drive the analyzer features proposed in https://bugs.webkit.org/show_bug.cgi?id=136515
Comment 1 Radar WebKit Bug Importer 2014-10-14 13:34:43 PDT 
<rdar://problem/18653753>
Comment 2 Jonathan Wells 2014-10-14 17:32:10 PDT 
Created attachment 239835 [details]
[PATCH] eslint addition.
Comment 3 WebKit Commit Bot 2014-10-14 17:33:59 PDT 
Attachment 239835 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 25 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2014-10-14 18:12:44 PDT 
Comment on attachment 239835 [details]
[PATCH] eslint addition.

Rejecting attachment 239835 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 239835, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 a4e96db7b75e498eb21099542d672c3be8ac186b ba16b4bd083807d8f83712188e0add6f23f36e66 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/5179812322738176
Comment 5 Jonathan Wells 2014-10-14 19:11:48 PDT 
What happened? Error. It mentions "Over 500 tabs" but not sure what would have caused that.
Comment 6 Jonathan Wells 2014-10-14 20:42:55 PDT 
Manually committed r174721: <https://trac.webkit.org/changeset/174721>
Comment 7 Jonathan Wells 2014-10-17 15:11:44 PDT 
Reopening as the patch broke the build. Need to insert 2-3 lines to fix.
Comment 8 Jonathan Wells 2014-10-17 16:05:08 PDT 
Created attachment 240048 [details]
[PATCH] eslint addition FIX.

Corrected patch. The file copy script needed another variable set for ESLint.js.
Comment 9 WebKit Commit Bot 2014-10-17 16:07:29 PDT 
Attachment 240048 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 25 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Jonathan Wells 2014-10-17 16:09:18 PDT 
Created attachment 240049 [details]
[PATCH] eslint addition FIX and CHANGELOG.

Forgot ChangeLog.
Comment 11 WebKit Commit Bot 2014-10-17 16:12:29 PDT 
Attachment 240049 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 25 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Jonathan Wells 2014-10-17 16:22:23 PDT 
Comment on attachment 240049 [details]
[PATCH] eslint addition FIX and CHANGELOG.

Mmm, still not copying correctly. Working more on this.
Comment 13 Jonathan Wells 2014-10-17 16:32:22 PDT 
Created attachment 240051 [details]
[PATCH] eslint addition FIX and CHANGELOG.
Comment 14 Jonathan Wells 2014-10-17 16:32:41 PDT 
Comment on attachment 240051 [details]
[PATCH] eslint addition FIX and CHANGELOG.

Corrected. Dry run works.
Comment 15 WebKit Commit Bot 2014-10-17 16:34:48 PDT 
Attachment 240051 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 25 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Jonathan Wells 2014-10-17 16:52:36 PDT 
Manually committed r174852: <https://trac.webkit.org/changeset/174852>
Comment 17 Andreas Kling 2014-11-13 16:16:19 PST 
Comment on attachment 240051 [details]
[PATCH] eslint addition FIX and CHANGELOG.

Removing r? since this was landed.