Bug 137714

Summary:

Web Inspector: Add ESLint open source library to the inspector

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] eslint addition.	timothy: review+, commit-queue: commit-queue-
[PATCH] eslint addition FIX.	none
[PATCH] eslint addition FIX and CHANGELOG.	none
[PATCH] eslint addition FIX and CHANGELOG.	none

Jonathan Wells

Reported 2014-10-14 13:33:57 PDT

Adding ESLint to drive the analyzer features proposed in https://bugs.webkit.org/show_bug.cgi?id=136515

Attachments
[PATCH] eslint addition. (609.80 KB, patch) 2014-10-14 17:32 PDT, Jonathan Wells	timothy: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
[PATCH] eslint addition FIX. (610.08 KB, patch) 2014-10-17 16:05 PDT, Jonathan Wells	no flags	Details Formatted Diff Diff
[PATCH] eslint addition FIX and CHANGELOG. (610.96 KB, patch) 2014-10-17 16:09 PDT, Jonathan Wells	no flags	Details Formatted Diff Diff
[PATCH] eslint addition FIX and CHANGELOG. (610.96 KB, patch) 2014-10-17 16:32 PDT, Jonathan Wells	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-10-14 13:34:43 PDT

<rdar://problem/18653753>

Jonathan Wells

Comment 2 2014-10-14 17:32:10 PDT

Created attachment 239835 [details] [PATCH] eslint addition.

WebKit Commit Bot

Comment 3 2014-10-14 17:33:59 PDT

Attachment 239835 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591: Line contains tab character. [whitespace/tab] [5] Total errors found: 25 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 4 2014-10-14 18:12:44 PDT

Comment on attachment 239835 [details] [PATCH] eslint addition. Rejecting attachment 239835 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 239835, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 a4e96db7b75e498eb21099542d672c3be8ac186b ba16b4bd083807d8f83712188e0add6f23f36e66 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/5179812322738176

Jonathan Wells

Comment 5 2014-10-14 19:11:48 PDT

What happened? Error. It mentions "Over 500 tabs" but not sure what would have caused that.

Jonathan Wells

Comment 6 2014-10-14 20:42:55 PDT

Manually committed r174721: <https://trac.webkit.org/changeset/174721>

Jonathan Wells

Comment 7 2014-10-17 15:11:44 PDT

Reopening as the patch broke the build. Need to insert 2-3 lines to fix.

Jonathan Wells

Comment 8 2014-10-17 16:05:08 PDT

Created attachment 240048 [details] [PATCH] eslint addition FIX. Corrected patch. The file copy script needed another variable set for ESLint.js.

WebKit Commit Bot

Comment 9 2014-10-17 16:07:29 PDT

Attachment 240048 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591: Line contains tab character. [whitespace/tab] [5] Total errors found: 25 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Wells

Comment 10 2014-10-17 16:09:18 PDT

Created attachment 240049 [details] [PATCH] eslint addition FIX and CHANGELOG. Forgot ChangeLog.

WebKit Commit Bot

Comment 11 2014-10-17 16:12:29 PDT

Attachment 240049 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591: Line contains tab character. [whitespace/tab] [5] Total errors found: 25 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Wells

Comment 12 2014-10-17 16:22:23 PDT

Comment on attachment 240049 [details] [PATCH] eslint addition FIX and CHANGELOG. Mmm, still not copying correctly. Working more on this.

Jonathan Wells

Comment 13 2014-10-17 16:32:22 PDT

Created attachment 240051 [details] [PATCH] eslint addition FIX and CHANGELOG.

Jonathan Wells

Comment 14 2014-10-17 16:32:41 PDT

Comment on attachment 240051 [details] [PATCH] eslint addition FIX and CHANGELOG. Corrected. Dry run works.

WebKit Commit Bot

Comment 15 2014-10-17 16:34:48 PDT

Attachment 240051 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8559: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8560: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8561: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8563: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8567: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8568: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8569: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8570: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8572: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8573: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8574: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8576: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8577: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8578: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8579: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8580: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8581: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8582: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8583: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8584: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8585: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8587: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8588: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8589: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebInspectorUI/UserInterface/External/ESLint/eslint.js:8591: Line contains tab character. [whitespace/tab] [5] Total errors found: 25 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Wells

Comment 16 2014-10-17 16:52:36 PDT

Manually committed r174852: <https://trac.webkit.org/changeset/174852>

Andreas Kling

Comment 17 2014-11-13 16:16:19 PST

Comment on attachment 240051 [details] [PATCH] eslint addition FIX and CHANGELOG. Removing r? since this was landed.

Note You need to log in before you can comment on or make changes to this bug.