Bug 137691

Summary: [Win32] Thunk is not implemented.
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description peavo 2014-10-14 06:56:58 PDT 
Thunks for functions with double operands (floor, etc.) are not implemented on Win32.
Comment 1 peavo 2014-10-14 06:59:50 PDT 
Created attachment 239797 [details]
Patch
Comment 2 Mark Lam 2014-10-14 08:47:40 PDT 
Comment on attachment 239797 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-10-14 09:25:27 PDT 
Comment on attachment 239797 [details]
Patch

Clearing flags on attachment: 239797

Committed r174682: <http://trac.webkit.org/changeset/174682>
Comment 4 WebKit Commit Bot 2014-10-14 09:25:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2014-10-14 10:29:04 PDT 
(In reply to comment #2)
> (From update of attachment 239797 [details])
> r=me

Thanks!
Comment 6 Konstantin Tokarev 2016-03-16 05:13:32 PDT 
Comment on attachment 239797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239797&action=review

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:813
> +// MSVC does not accept floor, etc, to be called directly from inline assembly, so we need to wrap these functions.

Is it still true for VS2015?