Bug 137688

Summary: Use modern loops in subtrees selection code
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Mihnea Ovidenie 2014-10-14 04:17:09 PDT 
Use modern loops in subtrees selection code
Comment 1 Mihnea Ovidenie 2014-10-14 04:20:15 PDT 
Created attachment 239792 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-14 04:22:26 PDT 
Attachment 239792 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderView.h:304:  The parameter name "end" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/rendering/RenderView.h:307:  The parameter name "end" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-10-14 11:50:12 PDT 
Comment on attachment 239792 [details]
Patch

r=me
Comment 4 Mihnea Ovidenie 2014-10-15 00:47:59 PDT 
Created attachment 239855 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-10-15 01:31:11 PDT 
Comment on attachment 239855 [details]
Patch for landing

Clearing flags on attachment: 239855

Committed r174725: <http://trac.webkit.org/changeset/174725>
Comment 6 WebKit Commit Bot 2014-10-15 01:31:14 PDT 
All reviewed patches have been landed.  Closing bug.