Bug 137688

Summary: Use modern loops in subtrees selection code
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2014-10-14 04:17:09 PDT
Use modern loops in subtrees selection code
Attachments
Patch (9.92 KB, patch)
2014-10-14 04:20 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.16 KB, patch)
2014-10-15 00:47 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2014-10-14 04:20:15 PDT
Created attachment 239792 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-14 04:22:26 PDT
Attachment 239792 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderView.h:304: The parameter name "end" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/RenderView.h:307: The parameter name "end" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-10-14 11:50:12 PDT
Comment on attachment 239792 [details] Patch r=me
Mihnea Ovidenie
Comment 4 2014-10-15 00:47:59 PDT
Created attachment 239855 [details] Patch for landing
WebKit Commit Bot
Comment 5 2014-10-15 01:31:11 PDT
Comment on attachment 239855 [details] Patch for landing Clearing flags on attachment: 239855 Committed r174725: <http://trac.webkit.org/changeset/174725>
WebKit Commit Bot
Comment 6 2014-10-15 01:31:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.