Bug 137683

Summary: Use is<>() / downcast<>() for RenderImage
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, mihnea, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137424, 137916    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-13 23:11:30 PDT
Use is<>() / downcast<>() for RenderImage
Attachments
Patch (40.14 KB, patch)
2014-10-13 23:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.06 KB, patch)
2014-10-14 01:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-13 23:20:30 PDT
Created attachment 239781 [details] Patch
Mihnea Ovidenie
Comment 2 2014-10-14 00:10:21 PDT
Comment on attachment 239781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239781&action=review r=me with comments similar to those in the review made by Darin for https://bugs.webkit.org/show_bug.cgi?id=137644 > Source/WebCore/editing/cocoa/HTMLConverter.mm:2534 > + RenderImage& renderer = downcast<RenderImage>(*element->renderer()); You can use auto& renderer instead of RenderImage& renderer. > Source/WebCore/html/HTMLAnchorElement.cpp:171 > + RenderImage& renderer = downcast<RenderImage>(*imageElement.renderer()); You can use auto& instead of RenderImage& > Source/WebCore/html/HTMLImageElement.cpp:239 > + RenderImage& renderImage = downcast<RenderImage>(*renderer()); You can use auto& instead of RenderImage&. > Source/WebCore/html/ImageInputType.cpp:111 > + RenderImage* renderer = downcast<RenderImage>(element().renderer()); You can use auto* instead of RenderImage* > Source/WebCore/html/ImageInputType.cpp:131 > + RenderImage* renderer = downcast<RenderImage>(element().renderer()); You can use auto* instead of RenderImage* > Source/WebCore/page/DragController.cpp:665 > + RenderImage& image = downcast<RenderImage>(*renderer); You can use auto& instead of RenderImage& > Source/WebCore/platform/win/PasteboardWin.cpp:729 > + RenderImage& renderer = downcast<RenderImage>(*element.renderer()); You can use auto& instead of RenderImage& > Source/WebCore/platform/win/PasteboardWin.cpp:865 > + RenderImage* image = downcast<RenderImage>(renderer); You can use auto* instead of RenderImage* > Source/WebCore/rendering/HitTestResult.cpp:297 > + RenderImage& image = downcast<RenderImage>(*renderer); You can use auto& instead of RenderImage& > Source/WebCore/rendering/RenderLayerBacking.cpp:1825 > + RenderImage& imageRenderer = downcast<RenderImage>(renderer()); You can use auto& instead of RenderImage& > Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm:226 > + RenderImage& imageRenderer = downcast<RenderImage>(*element->renderer()); You can use auto& instead of RenderImage&
Chris Dumez
Comment 3 2014-10-14 01:22:44 PDT
Created attachment 239785 [details] Patch
Chris Dumez
Comment 4 2014-10-14 01:23:27 PDT
Comment on attachment 239785 [details] Patch Thanks for reviewing, I made all the changes suggested.
WebKit Commit Bot
Comment 5 2014-10-14 02:07:24 PDT
Comment on attachment 239785 [details] Patch Clearing flags on attachment: 239785 Committed r174676: <http://trac.webkit.org/changeset/174676>
WebKit Commit Bot
Comment 6 2014-10-14 02:07:47 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2014-10-21 04:54:55 PDT
(In reply to comment #5) > Comment on attachment 239785 [details] > Patch > > Clearing flags on attachment: 239785 > > Committed r174676: <http://trac.webkit.org/changeset/174676> It broke the !ENABLE(VIDEO) build, see bug137916 for details.
Note You need to log in before you can comment on or make changes to this bug.