Summary: | Use is<>() / downcast<>() for RenderImage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, kling, mihnea, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 137424, 137916 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2014-10-13 23:11:30 PDT
Created attachment 239781 [details]
Patch
Comment on attachment 239781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239781&action=review r=me with comments similar to those in the review made by Darin for https://bugs.webkit.org/show_bug.cgi?id=137644 > Source/WebCore/editing/cocoa/HTMLConverter.mm:2534 > + RenderImage& renderer = downcast<RenderImage>(*element->renderer()); You can use auto& renderer instead of RenderImage& renderer. > Source/WebCore/html/HTMLAnchorElement.cpp:171 > + RenderImage& renderer = downcast<RenderImage>(*imageElement.renderer()); You can use auto& instead of RenderImage& > Source/WebCore/html/HTMLImageElement.cpp:239 > + RenderImage& renderImage = downcast<RenderImage>(*renderer()); You can use auto& instead of RenderImage&. > Source/WebCore/html/ImageInputType.cpp:111 > + RenderImage* renderer = downcast<RenderImage>(element().renderer()); You can use auto* instead of RenderImage* > Source/WebCore/html/ImageInputType.cpp:131 > + RenderImage* renderer = downcast<RenderImage>(element().renderer()); You can use auto* instead of RenderImage* > Source/WebCore/page/DragController.cpp:665 > + RenderImage& image = downcast<RenderImage>(*renderer); You can use auto& instead of RenderImage& > Source/WebCore/platform/win/PasteboardWin.cpp:729 > + RenderImage& renderer = downcast<RenderImage>(*element.renderer()); You can use auto& instead of RenderImage& > Source/WebCore/platform/win/PasteboardWin.cpp:865 > + RenderImage* image = downcast<RenderImage>(renderer); You can use auto* instead of RenderImage* > Source/WebCore/rendering/HitTestResult.cpp:297 > + RenderImage& image = downcast<RenderImage>(*renderer); You can use auto& instead of RenderImage& > Source/WebCore/rendering/RenderLayerBacking.cpp:1825 > + RenderImage& imageRenderer = downcast<RenderImage>(renderer()); You can use auto& instead of RenderImage& > Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm:226 > + RenderImage& imageRenderer = downcast<RenderImage>(*element->renderer()); You can use auto& instead of RenderImage& Created attachment 239785 [details]
Patch
Comment on attachment 239785 [details]
Patch
Thanks for reviewing, I made all the changes suggested.
Comment on attachment 239785 [details] Patch Clearing flags on attachment: 239785 Committed r174676: <http://trac.webkit.org/changeset/174676> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > Comment on attachment 239785 [details] > Patch > > Clearing flags on attachment: 239785 > > Committed r174676: <http://trac.webkit.org/changeset/174676> It broke the !ENABLE(VIDEO) build, see bug137916 for details. |