Summary: | Dashboard metrics page should have EWS statistics | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bshafiei, commit-queue, lforschler, rniwa, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-10-10 15:17:41 PDT
Also because we can't hide any platforms - everyone looks at all platforms for EWS. Created attachment 239655 [details]
proposed patch
So the result is a sizable chunk of text for each queue, e.g.:
mac-wk2
96% of patches had final results at first try. Time to result:
- median: 47 minutes;
- average: 43 minutes.
This includes 8% that did not apply to trunk.
2% of patches ceased to be eligible for processing before the first try finished.
2% of patches had to be retried, including 2% that kept being retried until the patch became ineligible for processing.
Median wait time before processing started: less than a minute.
Attachment 239655 [details] did not pass style-queue:
ERROR: Tools/QueueStatusServer/handlers/processingtimesjson.py:61: whitespace before '}' [pep8/E202] [5]
ERROR: Tools/QueueStatusServer/handlers/processingtimesjson.py:66: [ProcessingTimesJSON.get] Instance of 'ProcessingTimesJSON' has no 'response' member [pylint/E1101] [5]
ERROR: Tools/QueueStatusServer/handlers/processingtimesjson.py:67: [ProcessingTimesJSON.get] Instance of 'ProcessingTimesJSON' has no 'response' member [pylint/E1101] [5]
ERROR: Tools/QueueStatusServer/handlers/processingtimesjson.py:72: [ProcessingTimesJSON.get] Instance of 'ProcessingTimesJSON' has no 'response' member [pylint/E1101] [5]
Total errors found: 4 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 239655 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=239655&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:-34 > + "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName: "gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"}, > "mac-ews": {platform: Dashboard.Platform.MacOSXMountainLion, shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"}, > "mac-wk2-ews": {platform: Dashboard.Platform.MacOSXMountainLion, shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"}, > "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"}, > - "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName: "gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"}, Why are you moving GTK+ here? > Tools/QueueStatusServer/handlers/processingtimesjson.py:55 > + if not entry.attachment_id in result: > + result[entry.attachment_id] = {} result.setdefault(entry.attachment_id, {}) > Tools/QueueStatusServer/handlers/processingtimesjson.py:66 > + self.response.headers["Access-Control-Allow-Origin"] = "*" Should we use *.webkit.org & *.apple.com instead? > Why are you moving GTK+ here? Mentioned that in ChangeLog, it's to match the order of bubbles in Bugzilla. > > Tools/QueueStatusServer/handlers/processingtimesjson.py:66 > > + self.response.headers["Access-Control-Allow-Origin"] = "*" > > Should we use *.webkit.org & *.apple.com instead? We could, although not as easily. I don't think that it matters though. Committed <http://trac.webkit.org/r174622>. |