Bug 137622

Summary: Use is<>() / downcast<>() for RenderElement
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137424    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-10-10 12:58:21 PDT 
Use is<>() / downcast<>() for RenderElement
Comment 1 Chris Dumez 2014-10-10 13:01:47 PDT 
Created attachment 239644 [details]
Patch
Comment 2 Chris Dumez 2014-10-10 13:27:42 PDT 
Created attachment 239645 [details]
Patch
Comment 3 Chris Dumez 2014-10-10 14:00:52 PDT 
Created attachment 239647 [details]
Patch
Comment 4 Benjamin Poulain 2014-10-10 15:02:46 PDT 
Comment on attachment 239647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239647&action=review

> Source/WebCore/rendering/RenderCounter.cpp:624
> +            counterName ? WebCore::counterMaps().get(downcast<WebCore::RenderElement>(current))->get(identifier) : (WebCore::CounterNode*)1 : (WebCore::CounterNode*)0);

What the heck!

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:263
> +                        downcast<RenderSVGText>(*child).setNeedsTextMetricsUpdate();
> +                        downcast<RenderSVGText>(*child).setNeedsPositioningValuesUpdate();

IMHO, it would be cleaner to put downcast<RenderSVGText>(*child) in a temporary here.
Comment 5 Chris Dumez 2014-10-10 15:28:46 PDT 
Created attachment 239654 [details]
Patch
Comment 6 WebKit Commit Bot 2014-10-10 16:06:55 PDT 
Comment on attachment 239654 [details]
Patch

Clearing flags on attachment: 239654

Committed r174619: <http://trac.webkit.org/changeset/174619>
Comment 7 WebKit Commit Bot 2014-10-10 16:07:00 PDT 
All reviewed patches have been landed.  Closing bug.