Bug 137588

Summary:	requestAnimationFrame tests all time out in iOS simulator
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ryanhaddad, simon.fraser, thorton
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Simon Fraser (smfr) 2014-10-09 18:13:57 PDT

The fast/animation tests all time out. I will skip them.

Comment 1 Simon Fraser (smfr) 2016-01-03 11:01:06 PST

Still an issue?

Comment 2 Ryan Haddad 2016-01-04 10:42:28 PST

(In reply to comment #1)
> Still an issue?

I am running these tests locally to check.

Comment 3 Ryan Haddad 2016-01-04 10:53:08 PST

(In reply to comment #2)
> (In reply to comment #1)
> > Still an issue?
> 
> I am running these tests locally to check.

When run locally, all fast/animation tests pass except for:
fast/animation/request-animation-frame-disabled.html

--- /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-expected.txt
+++ /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS callbackInvoked is false
+FAIL callbackInvoked should be false. Was true.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Comment 4 Tim Horton 2016-01-04 11:16:01 PST

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Still an issue?
> > 
> > I am running these tests locally to check.
> 
> When run locally, all fast/animation tests pass except for:
> fast/animation/request-animation-frame-disabled.html
> 
> ---
> /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
> results/fast/animation/request-animation-frame-disabled-expected.txt
> +++
> /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
> results/fast/animation/request-animation-frame-disabled-actual.txt
> @@ -3,7 +3,7 @@
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
>  
>  
> -PASS callbackInvoked is false
> +FAIL callbackInvoked should be false. Was true.
>  PASS successfullyParsed is true
>  
>  TEST COMPLETE

So, I think we can close this bug and file one about WebKitRequestAnimationFrameEnabled not working. It does look like people use the pref legitimately so we should probably fix it.

Comment 5 Simon Fraser (smfr) 2016-01-04 11:21:42 PST

...and re-enable the tests

Comment 6 Ryan Haddad 2016-01-04 11:25:34 PST

Re-enabled the fast/animation directory in r194540, filed <https://bugs.webkit.org/show_bug.cgi?id=152701> for the failing test.