Bug 137588
| Summary: | requestAnimationFrame tests all time out in iOS simulator | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ryanhaddad, simon.fraser, thorton |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
The fast/animation tests all time out. I will skip them.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
Still an issue?
Ryan Haddad
(In reply to comment #1)
> Still an issue?
I am running these tests locally to check.
Ryan Haddad
(In reply to comment #2)
> (In reply to comment #1)
> > Still an issue?
>
> I am running these tests locally to check.
When run locally, all fast/animation tests pass except for:
fast/animation/request-animation-frame-disabled.html
--- /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-expected.txt
+++ /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/animation/request-animation-frame-disabled-actual.txt
@@ -3,7 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS callbackInvoked is false
+FAIL callbackInvoked should be false. Was true.
PASS successfullyParsed is true
TEST COMPLETE
Tim Horton
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Still an issue?
> >
> > I am running these tests locally to check.
>
> When run locally, all fast/animation tests pass except for:
> fast/animation/request-animation-frame-disabled.html
>
> ---
> /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
> results/fast/animation/request-animation-frame-disabled-expected.txt
> +++
> /Volumes/Data/git/OpenSource/WebKitBuild/Release-iphonesimulator/layout-test-
> results/fast/animation/request-animation-frame-disabled-actual.txt
> @@ -3,7 +3,7 @@
> On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
>
>
> -PASS callbackInvoked is false
> +FAIL callbackInvoked should be false. Was true.
> PASS successfullyParsed is true
>
> TEST COMPLETE
So, I think we can close this bug and file one about WebKitRequestAnimationFrameEnabled not working. It does look like people use the pref legitimately so we should probably fix it.
Simon Fraser (smfr)
...and re-enable the tests
Ryan Haddad
Re-enabled the fast/animation directory in r194540, filed <https://bugs.webkit.org/show_bug.cgi?id=152701> for the failing test.