Bug 137584

Summary: contributors.json is too long
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cdumez, commit-queue, glenn, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixed the format cdumez: review+

Ryosuke Niwa
Reported 2014-10-09 16:53:16 PDT
contributors.json is too long
Attachments
Fixed the format (184.85 KB, patch)
2014-10-09 16:53 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-10-09 16:53:52 PDT
Created attachment 239582 [details] Fixed the format
Ryosuke Niwa
Comment 2 2014-10-09 16:55:14 PDT
Comment on attachment 239582 [details] Fixed the format View in context: https://bugs.webkit.org/attachment.cgi?id=239582&action=review > Tools/ChangeLog:8 > + contributors.json is over 2000 lines! Revert the format change made in r150662 so that it's more managable. Actually 4700!
WebKit Commit Bot
Comment 3 2014-10-09 16:57:24 PDT
Attachment 239582 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2014-10-09 17:12:57 PDT
Comment on attachment 239582 [details] Fixed the format According to my quick diff, there seems to be a change in the Reviewers section, did you intentionally make a change?
Chris Dumez
Comment 5 2014-10-09 17:18:57 PDT
Something has changed for Antonio Gomes, could you check?
Chris Dumez
Comment 6 2014-10-09 17:39:59 PDT
Comment on attachment 239582 [details] Fixed the format View in context: https://bugs.webkit.org/attachment.cgi?id=239582&action=review r=me > Tools/Scripts/webkitpy/common/config/contributors.json:558 > + "expertise": "{ BlackBerry, EFL, Qt }WebKit ports, Hit testing, Touch/Event handling, Rendering and scrolling" }, You added an extra space after Qt :)
Chris Dumez
Comment 7 2014-10-09 17:40:37 PDT
Comment on attachment 239582 [details] Fixed the format View in context: https://bugs.webkit.org/attachment.cgi?id=239582&action=review >> Tools/Scripts/webkitpy/common/config/contributors.json:558 >> + "expertise": "{ BlackBerry, EFL, Qt }WebKit ports, Hit testing, Touch/Event handling, Rendering and scrolling" }, > > You added an extra space after Qt :) And before Blackberry as well.
Ryosuke Niwa
Comment 8 2014-11-03 09:01:02 PST
Apparently this change is controversial. Not fixing it.
Note You need to log in before you can comment on or make changes to this bug.