Bug 137571

Summary: Remove ENABLE_CSS3_CONDITIONAL_RULES
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=116554
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+

Dean Jackson
Reported 2014-10-09 13:43:35 PDT
Our support for @supports is pretty good (see https://bugs.webkit.org/show_bug.cgi?id=137569). I think we should enable it everywhere, and thus remove the compile time guard.
Attachments
Patch (67.42 KB, patch)
2014-10-09 14:38 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (67.37 KB, patch)
2014-10-09 14:47 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (62.92 KB, patch)
2014-10-09 15:05 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (67.08 KB, patch)
2014-10-09 15:14 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-10-09 14:38:09 PDT
Created attachment 239571 [details] Patch
Dean Jackson
Comment 2 2014-10-09 14:47:52 PDT
Created attachment 239573 [details] Patch
Dean Jackson
Comment 3 2014-10-09 15:00:43 PDT
I'm not sure why the patch isn't applying. It works fine here.
Dean Jackson
Comment 4 2014-10-09 15:05:51 PDT
Created attachment 239575 [details] Patch
Dean Jackson
Comment 5 2014-10-09 15:14:03 PDT
Created attachment 239576 [details] Patch
Dean Jackson
Comment 6 2014-10-09 15:33:16 PDT
https://trac.webkit.org/r174536
Brent Fulgham
Comment 7 2015-02-02 14:55:33 PST
Comment on attachment 239576 [details] Patch It's interesting that the "skips" were removed from the WinCairo port, but no the actual Apple Windows port. I think these should be enabled on Apple Windows as well.
Brent Fulgham
Comment 8 2015-02-02 14:56:47 PST
*** Bug 116554 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.