Summary: | [EFL] Crash on facebook.com | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | KwangHyuk <hyuki.kim> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
KwangHyuk
2014-10-09 12:07:57 PDT
Created attachment 239554 [details]
patch
Attachment 239554 [details] did not pass style-queue:
ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 239556 [details]
Patch
Comment on attachment 239556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review > Tools/MiniBrowser/efl/main.c:1531 > + window->popup.ewk_menu = NULL; Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call. (In reply to comment #4) > (From update of attachment 239556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review > > > Tools/MiniBrowser/efl/main.c:1531 > > + window->popup.ewk_menu = NULL; > > Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call. Thank you for your review. I will update the patch soon. :) Created attachment 239638 [details]
patch was updated.
Comment on attachment 239638 [details] patch was updated. Clearing flags on attachment: 239638 Committed r174625: <http://trac.webkit.org/changeset/174625> All reviewed patches have been landed. Closing bug. |