Bug 137562 – [EFL] Crash on facebook.com

• Component: WebKit EFL
• Status: RESOLVED FIXED

[KwangHyuk]

Crash occurs on the facebook.com when the webview is resized after the <select> item is clicked but no item is chosen.

#0  0x00007ffff20286b5 in WebKit::WebPopupMenuListenerEfl::valueChanged (this=0x21100000000, newSelectedIndex=525)
    at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.cpp:38
#1  0x00007ffff1f93cfe in WKPopupMenuListenerSetSelection (listenerRef=0x21100000000, selectedIndex=525)
    at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/C/efl/WKPopupMenuListener.cpp:36
#2  0x00007ffff1fc220e in EwkPopupMenu::close (this=0x20ad7a0)
    at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp:60
#3  0x00007ffff1fc2336 in ewk_popup_menu_close (popupMenu=0x20ad7a0)
    at /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu.cpp:94
#4  0x0000000000406811 in on_window_resize (user_data=0x6aee50, e=0x8000000300000019, 
    elm_window=0x80000002e0000018, event_info=0x0) at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:335
#5  0x00007fffec432573 in _eo_evas_object_cb (data=0x1a1d2c0, eo_obj=0x80000002e0000018, desc=<optimized out>, 
    event_info=0x0) at lib/evas/canvas/evas_callbacks.c:130
#6  0x00007fffe4b66b48 in _ev_cb_call (obj_id=0x80000002e0000018, class_data=0x6b9880, list=<optimized out>)
    at lib/eo/eo_base_class.c:690
#7  0x00007fffe4b61743 in _eo_op_internal (p_list=0x7fffffffd808, op=16, op_type=EO_OP_TYPE_REGULAR, 
    cur_klass=0x6b7de0, eo_ptr=0x6b9840, line=302, file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c")
    at lib/eo/eo.c:306
#8  _eo_dov_internal (p_list=0x7fffffffd808, op_type=EO_OP_TYPE_REGULAR, klass=0x6b7de0, obj=0x6b9840, line=302, 
    file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c") at lib/eo/eo.c:338
#9  _eo_obj_dov_internal (p_list=0x7fffffffd808, obj=0x6b9840, line=302, 
    file=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c") at lib/eo/eo.c:359
#10 eo_do_internal (file=file@entry=0x7fffec538b18 "lib/evas/canvas/evas_callbacks.c", line=line@entry=302, 
    obj_id=obj_id@entry=0x80000002e0000018) at lib/eo/eo.c:396
#11 0x00007fffec432a81 in evas_object_event_callback_call (eo_obj=0x80000002e0000018, obj=0x6b98b0, 
    type=EVAS_CALLBACK_RESIZE, event_info=0x0, event_id=13493) at lib/evas/canvas/evas_callbacks.c:302
#12 0x00007fffec46553e in evas_object_inform_call_resize (eo_obj=0x80000002e0000018)
    at lib/evas/canvas/evas_object_inform.c:41
#13 0x00007fffe4b61743 in _eo_op_internal (p_list=0x7fffffffd9d8, op=49, op_type=EO_OP_TYPE_REGULAR, 
    cur_klass=0x6b7de0, eo_ptr=0x6b9840, line=787, file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c")
    at lib/eo/eo.c:306
#14 _eo_dov_internal (p_list=0x7fffffffd9d8, op_type=EO_OP_TYPE_REGULAR, klass=0x6b7de0, obj=0x6b9840, line=787, 
    file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c") at lib/eo/eo.c:338
#15 _eo_obj_dov_internal (p_list=0x7fffffffd9d8, obj=0x6b9840, line=787, 
    file=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c") at lib/eo/eo.c:359
#16 eo_do_internal (file=file@entry=0x7fffec53e680 "lib/evas/canvas/evas_object_main.c", line=line@entry=787, 
    obj_id=<optimized out>) at lib/eo/eo.c:396
#17 0x00007fffec459738 in evas_object_resize (eo_obj=<optimized out>, w=<optimized out>, h=<optimized out>)
    at lib/evas/canvas/evas_object_main.c:787
#18 0x00007fffec95e045 in _elm_win_resize_job (data=<optimized out>) at elm_win.c:656
#19 0x00007fffed4c3dcb in _ecore_job_event_handler (data=<optimized out>, type=<optimized out>, ev=<optimized out>)
    at lib/ecore/ecore_job.c:153
#20 0x00007fffed4bea87 in _ecore_call_handler_cb (event=<optimized out>, type=<optimized out>, 
    data=<optimized out>, func=<optimized out>) at lib/ecore/ecore_private.h:359
#21 _ecore_event_call () at lib/ecore/ecore_events.c:562
#22 0x00007fffed4c5945 in _ecore_main_loop_iterate_internal (once_only=once_only@entry=0)
    at lib/ecore/ecore_main.c:2039
---Type <return> to continue, or q <return> to quit---
#23 0x00007fffed4c5c57 in ecore_main_loop_begin () at lib/ecore/ecore_main.c:1042
#24 0x000000000040cf26 in elm_main (argc=1, argv=0x7fffffffde58)
    at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:2368
#25 0x000000000040cf99 in main (argc=1, argv=0x7fffffffde58)
    at /home/hyuki/git/webkit2/Tools/MiniBrowser/efl/main.c:2372

[KwangHyuk]

Created attachment 239554 [details]
patch

[WebKit Commit Bot]

Attachment 239554 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[KwangHyuk]

Created attachment 239556 [details]
Patch

[Chris Dumez]

Comment on attachment 239556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review

> Tools/MiniBrowser/efl/main.c:1531
> +    window->popup.ewk_menu = NULL;

Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call.

[KwangHyuk]

(In reply to comment #4)
> (From update of attachment 239556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review
> 
> > Tools/MiniBrowser/efl/main.c:1531
> > +    window->popup.ewk_menu = NULL;
> 
> Makes sense but please move this below the elm_menu_close(). It is not nice to put this in between the elm_menu null check and the elm_menu_close() call.

Thank you for your review.
I will update the patch soon. :)

[KwangHyuk]

Created attachment 239638 [details]
patch was updated.

[WebKit Commit Bot]

Comment on attachment 239638 [details]
patch was updated.

Clearing flags on attachment: 239638

Committed r174625: <http://trac.webkit.org/changeset/174625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.