Bug 137552

Summary: MediaPlayer should use a reference for the MediaPlayerClient
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 21562    
Bug Blocks:    
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Carlos Garcia Campos
Reported 2014-10-09 01:17:32 PDT
It's currently a pointer that is checked almost everywhere before being used, and assumed to be non-null in a few places too. The client is set on constructor by HTMLMediaElement and cleared on HTMLMediaElement destructor that also frees the media player object. So, the client will never be null while the MediaPlayer player is alive.
Attachments
Patch (31.94 KB, patch)
2014-10-09 01:23 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (32.00 KB, patch)
2014-10-09 09:20 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-10-09 01:23:43 PDT
Created attachment 239524 [details] Patch
Carlos Garcia Campos
Comment 2 2014-10-09 09:20:34 PDT
Created attachment 239543 [details] Patch for landing
Carlos Garcia Campos
Comment 3 2014-10-09 23:56:44 PDT
Committed r174563: <http://trac.webkit.org/changeset/174563>
Note You need to log in before you can comment on or make changes to this bug.