Bug 137552

Summary:

MediaPlayer should use a reference for the MediaPlayerClient

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

21562

Bug Blocks:

Attachments:

Description	Flags
Patch	darin: review+
Patch for landing	none

Description Carlos Garcia Campos 2014-10-09 01:17:32 PDT

It's currently a pointer that is checked almost everywhere before being used, and assumed to be non-null in a few places too. The client is set on constructor by HTMLMediaElement and cleared on HTMLMediaElement destructor that also frees the media player object. So, the client will never be null while the MediaPlayer player is alive.

Comment 1 Carlos Garcia Campos 2014-10-09 01:23:43 PDT

Created attachment 239524 [details]
Patch

Comment 2 Carlos Garcia Campos 2014-10-09 09:20:34 PDT

Created attachment 239543 [details]
Patch for landing

Comment 3 Carlos Garcia Campos 2014-10-09 23:56:44 PDT

Committed r174563: <http://trac.webkit.org/changeset/174563>