Bug 137546

Summary: Add Babak to contributors.json and add historical email addresses for some contributors
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, bshafiei, burg, commit-queue, glenn, kling, mhahnenb, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Description Ryosuke Niwa 2014-10-08 20:18:11 PDT
contributors.json is used to analyze historical commit data and commit logs.
Add back historical email addresses for some contributors and also add Babak (Shafiei).
Comment 1 Ryosuke Niwa 2014-10-08 20:21:36 PDT
Created attachment 239511 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-08 20:25:28 PDT
Attachment 239511 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-10-08 20:28:05 PDT
Comment on attachment 239511 [details]
Patch

r=me
Comment 4 Alexey Proskuryakov 2014-10-08 22:19:27 PDT
> contributors.json is used to analyze historical commit data and commit logs.

And here am I hoping to remove all inactive contributors from this file, to make Bugzilla autocomplete work better...
Comment 5 Ryosuke Niwa 2014-10-09 08:11:07 PDT
(In reply to comment #4)
> > contributors.json is used to analyze historical commit data and commit logs.
> 
> And here am I hoping to remove all inactive contributors from this file, to make Bugzilla autocomplete work better...

We can add some flag to indicate they're inactive instead.
Comment 6 Alexey Proskuryakov 2014-10-09 10:59:53 PDT
Is analyzing historical data important enough to clutter this file? It seems like maintaining history is secondary to keeping the project going, so whoever is interested in that should just maintain their own, outside of webkit.org. We actively delete old unused code, so why keep old unused e-mails?
Comment 7 Ryosuke Niwa 2014-10-09 12:13:51 PDT
(In reply to comment #6)
> Is analyzing historical data important enough to clutter this file? It seems like maintaining history is secondary to keeping the project going, so whoever is interested in that should just maintain their own, outside of webkit.org. We actively delete old unused code, so why keep old unused e-mails?

Yes, it's important. Contributors.json is like a file based database, it's not intended to be read by humans directly.  For that, we have team.html and a command tool like webkit-patch find-users or webkitbot's whois command.
Comment 8 Ryosuke Niwa 2014-10-09 12:25:08 PDT
Let me put this way.  If a new contributor comes to #webkit and asks webkitbot who ojan is because he saw his name on a change log, then webkitbot should still be able to tell who that is even though Ojan will be considered as an inactive reviewer per recent discussion.

I agree we should hide inactive contributors to commit queue, watch list, Bugzilla auto completion, etc... but that doesn't require us to remove inactive contributors or emails from contributors.json.
Comment 9 Alexey Proskuryakov 2014-10-09 13:36:00 PDT
I don't think that I agree with that, using webkitbot to find a user seems like such a rare occurrence that maybe we should just remove the functionality outright, not optimize for it.

Keeping old affiliations and inactive e-mails also seems more harmful than useful, just like keeping stale ifdefed-out code.

But it's not a huge deal either way.
Comment 10 Brian Burg 2014-10-09 13:42:08 PDT
(In reply to comment #8)
> Let me put this way.  If a new contributor comes to #webkit and asks webkitbot who ojan is because he saw his name on a change log, then webkitbot should still be able to tell who that is even though Ojan will be considered as an inactive reviewer per recent discussion.

How will they know to ask webkitbot? Why would they ask webkitbot if Ojan's email is in the ChangeLog?

I don't think using contributors.json is a good basis for analyzing historical commit data. There are many contributors inside Apple and outside who are not in that file.

A serious software repository mining tool will have to deal with other issues anyway, such as contributors.json names not matching up with the name stored by git config. I am not convinced that keeping old entries in TOT will help much since repository mining will have to piece together metadata from old commits anyway.
Comment 11 Ryosuke Niwa 2014-10-09 16:16:27 PDT
Committed r174538: <http://trac.webkit.org/changeset/174538>