Bug 137516

Summary: [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, evab.u-szeged, glenn, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-10-08 02:46:09 PDT
[webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
Attachments
Patch (2.09 KB, patch)
2014-10-08 02:46 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-10-08 02:46:18 PDT
Created attachment 239463 [details] Patch
Csaba Osztrogonác
Comment 2 2014-10-08 02:49:57 PDT
ZipFile.extractall() in python is still buggy: https://bugs.webkit.org/show_bug.cgi?id=137338#c13 We should add back its workaround, of course. But why not use the bug free tar.gz if it works out of the box?
Csaba Osztrogonác
Comment 3 2014-10-08 08:50:26 PDT
( The workaround was added back in http://trac.webkit.org/changeset/174448. )
WebKit Commit Bot
Comment 4 2014-10-08 10:40:11 PDT
Comment on attachment 239463 [details] Patch Clearing flags on attachment: 239463 Committed r174461: <http://trac.webkit.org/changeset/174461>
WebKit Commit Bot
Comment 5 2014-10-08 10:40:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.