Summary: | ASSERTION FAILED: underlyingStringIsValid() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, mmaxfield | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2014-10-07 15:32:59 PDT
Created attachment 239436 [details]
Test case
An obvious bug: TextRun textRun(run.text()); The result of run.text() is a String, which is destroyed after changing TextRun to point to it. We need to put the string into a local variable. But also, run.text() should return a StringView, not a String. Created attachment 239453 [details]
Patch
I now understand why I didn’t hit this crash during my testing. The refactoring to use StringView in TextRun was done after my testing, and I think it introduced this bug. Comment on attachment 239453 [details]
Patch
Very nice!
Comment on attachment 239453 [details] Patch Clearing flags on attachment: 239453 Committed r174451: <http://trac.webkit.org/changeset/174451> All reviewed patches have been landed. Closing bug. |