Bug 137500

Summary: StyleQueue should throw a PatchIsNotValid exception to achieve consistency with CommitQueue and EWS
Product: WebKit Reporter: Jake Nielsen <jake.nielsen.webkit>
Component: Tools / TestsAssignee: Jake Nielsen <jake.nielsen.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the PatchIsNotValid throw to StyleQueue
none
Removes the redundant validate call from StyleQueue none

Jake Nielsen
Reported 2014-10-07 14:36:21 PDT
see https://bugs.webkit.org/show_bug.cgi?id=137460
Attachments
Adds the PatchIsNotValid throw to StyleQueue (5.42 KB, patch)
2014-10-07 14:52 PDT, Jake Nielsen 		no flags
DetailsFormatted DiffDiff
Removes the redundant validate call from StyleQueue (5.82 KB, patch)
2014-10-08 17:47 PDT, Jake Nielsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jake Nielsen
Comment 1 2014-10-07 14:52:39 PDT
Created attachment 239435 [details] Adds the PatchIsNotValid throw to StyleQueue
Alexey Proskuryakov
Comment 2 2014-10-07 14:57:16 PDT
Comment on attachment 239435 [details] Adds the PatchIsNotValid throw to StyleQueue Don't we need to also remove an existing validate() call from StyleQueue?
Jake Nielsen
Comment 3 2014-10-08 17:47:15 PDT
Created attachment 239507 [details] Removes the redundant validate call from StyleQueue
Alexey Proskuryakov
Comment 4 2014-10-08 23:13:21 PDT
Comment on attachment 239507 [details] Removes the redundant validate call from StyleQueue View in context: https://bugs.webkit.org/attachment.cgi?id=239507&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:327 > + return False I wonder if we should stop returning values from process_work_item; the caller doesn't do anything meaningful with them. > Tools/Scripts/webkitpy/tool/commands/queues.py:467 > + return False And maybe ones in review_patch functions too. It's quite confusing that each subclass is responsible to all results except for _did_pass, it seems better to make them call _did_pass, too.
WebKit Commit Bot
Comment 5 2014-10-08 23:50:52 PDT
Comment on attachment 239507 [details] Removes the redundant validate call from StyleQueue Clearing flags on attachment: 239507 Committed r174501: <http://trac.webkit.org/changeset/174501>
WebKit Commit Bot
Comment 6 2014-10-08 23:50:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.