| Summary: | Remove build warnings in Hashmap API tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tanay <tanay.c> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 239407 [details]
Patch
Comment on attachment 239407 [details] Patch Clearing flags on attachment: 239407 Committed r174418: <http://trac.webkit.org/changeset/174418> All reviewed patches have been landed. Closing bug. |
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:450:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:472:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingMoveKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:494:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:559:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:580:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry);