Bug 137482

Summary: [GTK] jhbuild modules should build xserver with the --without-dtrace option
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebKitGTKAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2014-10-07 00:51:23 PDT
If the --without-dtrace is not used, compilation of xserver is currently broken on Fedora 20.
Comment 1 youenn fablet 2014-10-07 00:55:27 PDT
Created attachment 239400 [details]
Patch
Comment 2 Michael Catanzaro 2014-10-07 06:35:31 PDT
Hm, it's broken for me too. The error message is:

  GEN      dtrace-dix.o
/usr/bin/dtrace:/tmp/tmpH1C5vv.d:34 syntax error near:
typedef unsigned short int __u_short;

Since we don't explicitly enable or disable dtrace, it's enabled only if you have /sbin/dtrace and /usr/include/sys/sdt.h. (On Fedora those are provided by the package systemtap-sdt-devel.)
Comment 3 Martin Robinson 2014-10-07 07:12:40 PDT
Is there a missing package that can fix the issue as well? I think we should weigh the two options.
Comment 4 youenn fablet 2014-10-07 08:33:58 PDT
(In reply to comment #3)
> Is there a missing package that can fix the issue as well? I think we should weigh the two options.

The related redhat bug is : https://bugzilla.redhat.com/show_bug.cgi?id=1131586

There are different possible fixes.
The simplest solution is probably to disable dtrace but I am fine with other local temp fixes.
Comment 5 WebKit Commit Bot 2014-10-07 09:12:06 PDT
Comment on attachment 239400 [details]
Patch

Clearing flags on attachment: 239400

Committed r174396: <http://trac.webkit.org/changeset/174396>
Comment 6 WebKit Commit Bot 2014-10-07 09:12:10 PDT
All reviewed patches have been landed.  Closing bug.