Bug 137446

Summary: [jhbuild] We should be able to disable wiping on configuration change
Product: WebKit Reporter: Tibor Mészáros <mtiborinf>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ossy: review-, ossy: commit-queue-
Patch v2
none
Patch v3 none

Tibor Mészáros
Reported 2014-10-06 03:15:53 PDT
It is annoying that jhbuild automatically and mandatory wipes the full Dependencies directory during hacking jhbuildrc files. We should be able to disable this function with a command line option and/or with an environment variable.
Attachments
Patch (1.54 KB, patch)
2014-10-06 03:24 PDT, Tibor Mészáros 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (1.70 KB, patch)
2014-10-06 05:41 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Patch v3 (1.69 KB, patch)
2014-10-06 06:07 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tibor Mészáros
Comment 1 2014-10-06 03:24:05 PDT
Created attachment 239324 [details] Patch This patch will add a new flag --wipe-on-change to disable wiping on configuration change
Csaba Osztrogonác
Comment 2 2014-10-06 03:35:07 PDT
Comment on attachment 239324 [details] Patch The patch looks good to me, but the comment is misleading. $wipeOnChange has true default value, but can be disabled with - JHBUILD_WIPE_ON_CHANGE=0 environment variable (or) - --no-wipe-on-change command line option
Csaba Osztrogonác
Comment 3 2014-10-06 03:44:03 PDT
Comment on attachment 239324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239324&action=review > Tools/Scripts/update-webkit-libs-jhbuild:34 > +GetOptions('wipe-on-change' => \$wipeOnChange,); You meant 'wipe-on-change!' to have --no-wipe-on-change and --wipe-on-change options too.
Tibor Mészáros
Comment 4 2014-10-06 05:41:07 PDT
Created attachment 239330 [details] Patch v2 This patch has a better description.
Tibor Mészáros
Comment 5 2014-10-06 06:07:58 PDT
Created attachment 239333 [details] Patch v3 Updated description
WebKit Commit Bot
Comment 6 2014-10-10 03:25:27 PDT
Comment on attachment 239333 [details] Patch v3 Clearing flags on attachment: 239333 Committed r174580: <http://trac.webkit.org/changeset/174580>
WebKit Commit Bot
Comment 7 2014-10-10 03:25:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.