[jhbuild] We should be able to disable wiping on configuration change

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tibor Mészáros]

It is annoying that jhbuild automatically and mandatory wipes the full Dependencies directory
during hacking jhbuildrc files. We should be able to disable this function with a command line option
and/or with an environment variable.

[Tibor Mészáros]

Created attachment 239324 [details]
Patch

This patch will add a new flag --wipe-on-change to disable wiping on configuration change

[Csaba Osztrogonác]

Comment on attachment 239324 [details]
Patch

The patch looks good to me, but the comment is misleading.

$wipeOnChange has true default value, but can be disabled with
- JHBUILD_WIPE_ON_CHANGE=0 environment variable (or)
- --no-wipe-on-change command line option

[Csaba Osztrogonác]

Comment on attachment 239324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239324&action=review

> Tools/Scripts/update-webkit-libs-jhbuild:34
> +GetOptions('wipe-on-change' => \$wipeOnChange,);

You meant 'wipe-on-change!' to have --no-wipe-on-change and --wipe-on-change options too.

[Tibor Mészáros]

Created attachment 239330 [details]
Patch v2

This patch has a better description.

[Tibor Mészáros]

Created attachment 239333 [details]
Patch v3

Updated description

[WebKit Commit Bot]

Comment on attachment 239333 [details]
Patch v3

Clearing flags on attachment: 239333

Committed r174580: <http://trac.webkit.org/changeset/174580>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.