| Summary: | [EFL][CoordinatedGraphics] All EFL layout tests are broken since r174231 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
| Component: | WebKit2 | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, luiz, noam, ossy, ryuan.choi, sergio, zeno, zherczeg | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 137384, 137848 | ||||||||||||||
| Bug Blocks: | 137164 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Gyuyoung Kim
2014-10-06 00:48:43 PDT
Created attachment 239316 [details]
Patch
CC'ing Ossy. Ossy, could you take a look this patch ? Created attachment 239317 [details]
Patch
(In reply to comment #2) > CC'ing Ossy. Ossy, could you take a look this patch ? Sorry, I don't know how Coordinated Graphics works, maybe Zoltán can help you, cc-ing him too. With this patch tests still fail for me, but with different log: ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs ERR<9189>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:479 _ecore_evas_x_gl_window_new() evas_engine_info_set() for engine 'opengl_x11' failed. Xlib: extension "GLX" missing on display ":1". ERR<9189>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL engine not available. #PROCESS UNRESPONSIVE - WebProcess I checked r174230 too, everything worked fine that time. (In reply to comment #5) > With this patch tests still fail for me, but with different log: > ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs > ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs > ERR<9189>:evas-gl_x11 modules/evas/engines/gl_x11/evas_x_main.c:767 eng_best_visual_get() glXChooseFBConfig returned no configs > ERR<9189>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:479 _ecore_evas_x_gl_window_new() evas_engine_info_set() for engine 'opengl_x11' failed. > Xlib: extension "GLX" missing on display ":1". > ERR<9189>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL engine not available. > #PROCESS UNRESPONSIVE - WebProcess > > > I checked r174230 too, everything worked fine that time. Hmm.. weird, this error message is not related webkit but EFL. (In reply to comment #6) > Hmm.. > weird, this error message is not related webkit but EFL. I don't get this error with r174230, but with ToT WebKit with this patch, so I think it is somehow related to a recent WebKit change. (In reply to comment #7) > (In reply to comment #6) > > Hmm.. > > weird, this error message is not related webkit but EFL. > > I don't get this error with r174230, but with ToT WebKit with this > patch, so I think it is somehow related to a recent WebKit change. I don't get your error message when I run MiniBrowser this patch. gyuyoung@gyuyoung:~/webkit/WebKit$ WebKitBuild/Release/bin/MiniBrowser HTML5 local storage is enabled for this view. ERR<32329>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files (In reply to comment #4) > (In reply to comment #2) > > CC'ing Ossy. Ossy, could you take a look this patch ? > > Sorry, I don't know how Coordinated Graphics works, > maybe Zoltán can help you, cc-ing him too. If Zoltan can review this patch, I haven't seen him for a long time. As you know, we need to fix EFL layout test as soon as possible. It has broken since last Friday. (In reply to comment #9) Wrong typing > If Zoltan can review this patch, I haven't seen him for a long time. => If Zoltan can review this patch, it is nice. However, I haven't seen him for a long time. I think this is an acceptable workaround for the moment. (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Hmm.. > > > weird, this error message is not related webkit but EFL. > > > > I don't get this error with r174230, but with ToT WebKit with this > > patch, so I think it is somehow related to a recent WebKit change. > > > I don't get your error message when I run MiniBrowser this patch. I do during run layout tests and performance tests too, however MiniBrowser looks working with this workaround. (In reply to comment #12) typo fix: I do get during ... Comment on attachment 239317 [details]
Patch
I also get similar error when running EFL layout test locally. Let me take a look this further.
Ossy and Ryuan, r174335 broke EFL layout test regardless of Pageoverlay moving. https://trac.webkit.org/changeset/174335 To restore EFL layout test, we should revert it first. Created attachment 239462 [details]
Patch
Zoltan and Ossy, previous layout test problem was caused by Ryuan's patch, which couldn't be detected since EFL layout test was already broken. I revert it through r174423. Besides I apply r174231's change regarding viewOverlayRootLayer to coordinated graphics in new patch. I think this is more closer to Mac port implementation. Created attachment 239464 [details]
Patch
(In reply to comment #18) > Created an attachment (id=239464) [details] > Patch I can confirm, MiniBrowser, layout tests and performance tests work on top of trunk with this patch on my Ubuntu 14.04. machine. This patch makes sense. Lets wait for the bots. (In reply to comment #20) > This patch makes sense. Lets wait for the bots. It touches only coordinated graphics sources which is used by only EFL, so there is no reason to wait for them. ( Otherwise Win and GTK EWS are dead. ) Created attachment 239466 [details]
Patch
(In reply to comment #21) > (In reply to comment #20) > > This patch makes sense. Lets wait for the bots. > > It touches only coordinated graphics sources which is used by only EFL, > so there is no reason to wait for them. ( Otherwise Win and GTK EWS are dead. ) To check whether ews are dead, I upload patch again. Comment on attachment 239466 [details]
Patch
You are right.
Comment on attachment 239466 [details] Patch Clearing flags on attachment: 239466 Committed r174435: <http://trac.webkit.org/changeset/174435> All reviewed patches have been landed. Closing bug. (In reply to comment #24) > (From update of attachment 239466 [details]) > You are right. I land this patch manually since ews looks like dead. Zoltan and Ossy, thank you for review !! (In reply to comment #15) > Ossy and Ryuan, r174335 broke EFL layout test regardless of Pageoverlay moving. > https://trac.webkit.org/changeset/174335 > > To restore EFL layout test, we should revert it first. Sorry for the inconvenience. I just caught what's wrong. Thanks for the revert. |