Bug 137438

Summary:

Use is<>() / downcast<>() for TextTrack subclasses

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, calvaris, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kling, philipj, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137056

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2014-10-05 17:39:15 PDT

Use is<>() / downcast<>() for TextTrack subclasses

Comment 1 Chris Dumez 2014-10-05 17:43:20 PDT

Created attachment 239308 [details]
Patch

Comment 2 Ryosuke Niwa 2014-10-05 21:35:05 PDT

Comment on attachment 239308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239308&action=review

> Source/WebCore/html/track/TextTrackList.cpp:54
> -int TextTrackList::getTrackIndex(TextTrack *textTrack)
> +int TextTrackList::getTrackIndex(TextTrack* textTrack)

We don't have to do it in this patch but we should use reference for textTrack.

Comment 3 WebKit Commit Bot 2014-10-05 22:11:00 PDT

Comment on attachment 239308 [details]
Patch

Clearing flags on attachment: 239308

Committed r174338: <http://trac.webkit.org/changeset/174338>

Comment 4 WebKit Commit Bot 2014-10-05 22:11:08 PDT

All reviewed patches have been landed.  Closing bug.