Bug 137417 – Add a deprecation warning for Element.webkitMatchesSelector

• Component: New Bugs
• Status: RESOLVED LATER

[Benjamin Poulain]

Add a deprecation warning for Element.webkitMatchesSelector

[Benjamin Poulain]

Created attachment 239261 [details]
Patch

[Build Bot]

Comment on attachment 239261 [details]
Patch

Attachment 239261 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6194595117400064

New failing tests:
jquery/data.html
jquery/deferred.html
jquery/manipulation.html
jquery/core.html
fast/dom/SelectorAPI/undefined-null-stringify.html
jquery/css.html
jquery/offset.html
fast/dom/SelectorAPI/detached-element.html
jquery/event.html
jquery/traversing.html
fast/dom/SelectorAPI/caseID.html
fast/dom/SelectorAPI/caseID-almost-strict.html
jquery/attributes.html
jquery/dimensions.html
fast/dom/SelectorAPI/attrname-case-sensitive.xhtml
fast/forms/radio/radio-live-validation-style.html
fast/dom/SelectorAPI/caseTag.html
fast/dom/SelectorAPI/caseTagX.xhtml
fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/not-supported-namespace-in-selector.html
fast/dom/SelectorAPI/attrname-case-insensitive.html

[Build Bot]

Created attachment 239263 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Benjamin Poulain]

Comment on attachment 239261 [details]
Patch

Arg, of course.

[Build Bot]

Comment on attachment 239261 [details]
Patch

Attachment 239261 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5009325072318464

New failing tests:
jquery/data.html
jquery/deferred.html
jquery/manipulation.html
jquery/core.html
fast/dom/SelectorAPI/undefined-null-stringify.html
jquery/css.html
jquery/offset.html
fast/dom/SelectorAPI/detached-element.html
jquery/event.html
jquery/traversing.html
fast/dom/SelectorAPI/caseID.html
fast/dom/SelectorAPI/caseID-almost-strict.html
jquery/attributes.html
jquery/dimensions.html
fast/dom/SelectorAPI/attrname-case-sensitive.xhtml
fast/forms/radio/radio-live-validation-style.html
fast/dom/SelectorAPI/caseTag.html
fast/dom/SelectorAPI/caseTagX.xhtml
fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/not-supported-namespace-in-selector.html
fast/dom/SelectorAPI/attrname-case-insensitive.html

[Build Bot]

Created attachment 239266 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Benjamin Poulain]

Created attachment 239270 [details]
Patch

[Chris Dumez]

Comment on attachment 239270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239270&action=review

> Source/WebCore/ChangeLog:12
> +        This patch add a deprecation warning for Element.webkitMatchesSelector with the hope

Nit: "adds"

> LayoutTests/jquery/resources/src/sizzle/sizzle.js:1203
> +		matches = html.matches || html.mozMatchesSelector || html.webkitMatchesSelector || html.msMatchesSelector,

I don't know what's the policy about editing scripts in the jquery folder. Aren't we supposed to keep it matching upstream?

[Chris Dumez]

r=me

[Benjamin Poulain]

Thanks for the review.

(In reply to comment #8)
> > LayoutTests/jquery/resources/src/sizzle/sizzle.js:1203
> > +		matches = html.matches || html.mozMatchesSelector || html.webkitMatchesSelector || html.msMatchesSelector,
> 
> I don't know what's the policy about editing scripts in the jquery folder. Aren't we supposed to keep it matching upstream?

Yep, that's indeed the policy.

I am doing an exception here because:
-Updating the jquery tests is out of scope for this patch.
-The real sizzle has been updated a long time ago (https://github.com/jquery/sizzle/blob/master/src/sizzle.js#L672). Better keep the test coverage for everything else.

[Benjamin Poulain]

Committed r174336: <http://trac.webkit.org/changeset/174336>

[Csaba Osztrogonác]

(In reply to comment #11)
> Committed r174336: <http://trac.webkit.org/changeset/174336>

It broke 5 performance tests because of jquery:

Running Dromaeo/cssquery-jquery.html (49 of 140)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 181.807474 s

Running Dromaeo/jslib-attr-jquery.html (61 of 140)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 31.081577 s

Running Dromaeo/jslib-event-jquery.html (63 of 140)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 34.961821 s

Running Dromaeo/jslib-style-jquery.html (66 of 140)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 41.230456 s

Running Dromaeo/jslib-traverse-jquery.html (68 of 140)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 41.187652 s

[Benjamin Poulain]

(In reply to comment #12)
> (In reply to comment #11)
> > Committed r174336: <http://trac.webkit.org/changeset/174336>
> 
> It broke 5 performance tests because of query.

Thanks for tracking that. We should find if the real Dromaeo uses webkitMatchesSelector. If it does, we'll have to revert this deprecation warning :(

[Carlos Alberto Lopez Perez]

(In reply to comment #12)
> (In reply to comment #11)
> > Committed r174336: <http://trac.webkit.org/changeset/174336>
> 
> It broke 5 performance tests because of jquery:
> 

After r174359 <http://trac.webkit.org/r174359> fixed the crash on the performance test Speedometer/Full.html, this test is also failing with the same output.

$ Tools/Scripts/run-perf-tests  --platform gtk --release -2 Speedometer/Full.html
Running 1 tests
Running Speedometer/Full.html (1 of 1)
ERROR: CONSOLE MESSAGE: Element.webkitMatchesSelector is deprecated. Use Element.matches instead.
FAILED
Finished: 77.595549 s

So, the number of tests broken is 6.

[Benjamin Poulain]

Committed r174363: <http://trac.webkit.org/changeset/174363>

[Benjamin Poulain]

The original tests still use an old sizzle. I reverted the patch :(