Bug 137399

Summary:

webkit-appearance: default-button styling does not set the button font color to white

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	hyatt: review+

Description Dean Jackson 2014-10-03 13:11:07 PDT

webkit-appearance: default-button styling does not set the button font color to white

Comment 1 Dean Jackson 2014-10-03 13:19:11 PDT

Created attachment 239222 [details]
Patch

Comment 2 Dean Jackson 2014-10-03 13:19:40 PDT

rdar://problem/17788616

Comment 3 WebKit Commit Bot 2014-10-03 13:20:33 PDT

Attachment 239222 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.h:468:  _insideDefaultButton is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Dave Hyatt 2014-10-03 13:23:42 PDT

Comment on attachment 239222 [details]
Patch

r=me

Comment 5 Dean Jackson 2014-10-03 13:27:48 PDT

Committed r174283: <http://trac.webkit.org/changeset/174283>