| Summary: | CSS Selectors Level 4: Implement :matches in SelectorChecker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2014-10-03 06:39:08 PDT
Created attachment 239839 [details]
Patch
Added WIP patch, not enough tests are added, I'll add them later and update the patch. Woot! I can't wait :) Created attachment 239931 [details]
Patch
(In reply to comment #3) > Woot! I can't wait :) Yay! Added initial implementation with test cases based on the not-selector-list test :) In this implementation, pseudo element is not considered. I'll create the issue for supporting that. Comment on attachment 239931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239931&action=review Looks like a good start for the baseline, the patch looks correct to me. I did not check the actual test results but the test themselves seem to cover the important use cases. > Source/WebCore/ChangeLog:9 > + In this current implementation, we don't consider about pseudo elements. You can drop the "about". > LayoutTests/fast/selectors/querySelector-matches.html:68 > +// When using querySelector, the pseudo element produces the unmatch. "produces the unmatch" -> "cannot match"? Comment on attachment 239931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239931&action=review Thank you for your review! After landing this patch, I'll extend the SelectorChecker to annotate multiple pseudo elements at once. >> Source/WebCore/ChangeLog:9 >> + In this current implementation, we don't consider about pseudo elements. > > You can drop the "about". Thanks! Done. >> LayoutTests/fast/selectors/querySelector-matches.html:68 >> +// When using querySelector, the pseudo element produces the unmatch. > > "produces the unmatch" -> "cannot match"? Right. I'll fix this to "the selectors containing the pseudo elements cannot match". Committed r174811: <http://trac.webkit.org/changeset/174811> |