Bug 137385

Summary: Netscape plugin API symbol used outside feature guards
Product: WebKit Reporter: Philip Chimento <philip.chimento>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.9   
Attachments:
Description Flags
Patch
none
Patch none

Philip Chimento
Reported 2014-10-03 01:02:31 PDT
When building with the netscape plugin API turned off, I get an undefined symbol m_NPP_Shutdown(). The attached patch surrounds it by feature guards.
Attachments
Patch (519 bytes, patch)
2014-10-03 01:02 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Patch (1.15 KB, patch)
2014-10-06 22:05 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philip Chimento
Comment 1 2014-10-03 01:02:56 PDT
Created attachment 239189 [details] Patch
Philip Chimento
Comment 2 2014-10-06 22:05:26 PDT
Created attachment 239385 [details] Patch
Philip Chimento
Comment 3 2014-10-06 22:16:01 PDT
Attached an updated patch with ChangeLog.
Philip Chimento
Comment 4 2014-10-06 22:21:17 PDT
PS. I'd appreciate it if this could also be committed to the webkitgtk 2.4 branch.
Philippe Normand
Comment 5 2014-10-08 09:59:22 PDT
Once the patch landed please add it to the list: http://trac.webkit.org/wiki/WebKitGTK/2.4.x
WebKit Commit Bot
Comment 6 2014-10-09 00:34:48 PDT
Comment on attachment 239385 [details] Patch Clearing flags on attachment: 239385 Committed r174502: <http://trac.webkit.org/changeset/174502>
WebKit Commit Bot
Comment 7 2014-10-09 00:34:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.