Bug 137372

Summary:

Use version number 101000 instead of 10100 for OS X Yosemite

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ddkilzer, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrowe: review+

Description Daniel Bates 2014-10-02 17:18:19 PDT

We use 10100 to refer to Yosemite in at least two files:

In -[WebView _preferencesChanged:] in file Source/WebKit/mac/WebView/WebView.mm, <http://trac.webkit.org/browser/trunk/Source/WebKit/mac/WebView/WebView.mm?rev=173804&format=txt>
On line 41 (as of r172542) in file Tools/DumpRenderTree/mac/TextInputController.m, <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/TextInputController.m?rev=172542#L41>

The version number for Yosemite is 101000 according to the value of MAC_OS_X_VERSION_10_10 in AvailabilityMacros.h in the OS X Yosemite SDK.

Comment 1 Daniel Bates 2014-10-02 17:19:53 PDT

Created attachment 239160 [details]
Patch

Comment 2 Mark Rowe (bdash) 2014-10-02 17:22:24 PDT

Comment on attachment 239160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239160&action=review

> Source/WebKit/mac/ChangeLog:3
> +        Clean up: Use version number 101000 instead of 10100 for OS X Yosemite

This isn't really cleanup. It's a correctness issue.

Comment 3 Daniel Bates 2014-10-02 17:31:06 PDT

Committed r174251: <http://trac.webkit.org/changeset/174251>