Bug 137369

Summary:

makeString and tryMakeString should use variadic templates

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

benjamin, buildbot, cmarcelo, commit-queue, rniwa, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none

Anders Carlsson

Reported 2014-10-02 16:25:05 PDT

makeString and tryMakeString should use variadic templates

Attachments
Patch (29.90 KB, patch) 2014-10-02 16:29 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (293.75 KB, application/zip) 2014-10-02 17:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (112.70 KB, application/zip) 2014-10-02 18:44 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (188.85 KB, application/zip) 2014-10-02 20:44 PDT, Build Bot	no flags	Details
Patch (31.92 KB, patch) 2014-10-03 12:59 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (32.24 KB, patch) 2014-10-03 13:29 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (33.19 KB, patch) 2014-10-03 13:58 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (231.76 KB, application/zip) 2014-10-03 15:30 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (128.78 KB, application/zip) 2014-10-03 16:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (128.85 KB, application/zip) 2014-10-03 18:24 PDT, Build Bot	no flags	Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2014-10-02 16:29:17 PDT

Created attachment 239153 [details] Patch

Build Bot

Comment 2 2014-10-02 17:56:42 PDT

Comment on attachment 239153 [details] Patch Attachment 239153 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4550279773028352 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2014-10-02 17:56:44 PDT

Created attachment 239166 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-10-02 18:44:54 PDT

Comment on attachment 239153 [details] Patch Attachment 239153 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5327563626905600 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2014-10-02 18:44:58 PDT

Created attachment 239170 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-10-02 20:44:24 PDT

Comment on attachment 239153 [details] Patch Attachment 239153 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4587020265455616 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2014-10-02 20:44:28 PDT

Created attachment 239174 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Anders Carlsson

Comment 8 2014-10-03 12:59:32 PDT

Created attachment 239221 [details] Patch

Anders Carlsson

Comment 9 2014-10-03 13:29:58 PDT

Created attachment 239226 [details] Patch

Anders Carlsson

Comment 10 2014-10-03 13:58:18 PDT

Created attachment 239228 [details] Patch

Build Bot

Comment 11 2014-10-03 15:30:33 PDT

Comment on attachment 239228 [details] Patch Attachment 239228 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5761822669930496 Number of test failures exceeded the failure limit.

Build Bot

Comment 12 2014-10-03 15:30:36 PDT

Created attachment 239244 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Anders Carlsson

Comment 13 2014-10-03 15:51:39 PDT

Looks like this is hitting some sort of compiler bug on 10.8 :(

Build Bot

Comment 14 2014-10-03 16:27:03 PDT

Comment on attachment 239228 [details] Patch Attachment 239228 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5167044592926720 Number of test failures exceeded the failure limit.

Build Bot

Comment 15 2014-10-03 16:27:08 PDT

Created attachment 239251 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 16 2014-10-03 18:24:31 PDT

Comment on attachment 239228 [details] Patch Attachment 239228 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6222516699791360 Number of test failures exceeded the failure limit.

Build Bot

Comment 17 2014-10-03 18:24:35 PDT

Created attachment 239258 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Zan Dobersek

Comment 18 2015-08-04 00:38:40 PDT

*** This bug has been marked as a duplicate of bug 147142 ***

Csaba Osztrogonác

Comment 19 2015-09-14 10:49:07 PDT

Comment on attachment 239228 [details] Patch Cleared review? from attachment 239228 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.