Bug 137363

Summary:

Eliminate update-work-items

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

commit-queue, glenn, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Alexey Proskuryakov

Reported 2014-10-02 15:17:52 PDT

Commit queue and EWS feeders work differently: - EWS feeder submits attachments individually via submit-to-ews. - commit queue send the whole list of eligible attachments at once, and then the server figures out which are new, and which disappeared from the queue. This doesn't have to be different. Directly manipulating WorkItems from the client is confusing and racy, as the bot will continue processing even if the item is removed (and then the user can start another commit queue with the same patch by flipping cq+ back).

Attachments
proposed patch (23.86 KB, patch) 2014-10-02 15:25 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2014-10-02 15:25:23 PDT

Created attachment 239148 [details] proposed patch

WebKit Commit Bot

Comment 2 2014-10-02 15:28:29 PDT

Attachment 239148 [details] did not pass style-queue: ERROR: Tools/QueueStatusServer/model/workitems.py:68: [WorkItems.add_work_item] Instance of 'WorkItems' has no 'key' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/model/workitems.py:72: [WorkItems.add_high_priority_work_item] Instance of 'WorkItems' has no 'key' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:37: [SubmitToQueue.get] Instance of 'SubmitToQueue' has no 'response' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:40: [SubmitToQueue._queue_from_request] Instance of 'SubmitToQueue' has no 'request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:43: [SubmitToQueue._queue_from_request] Instance of 'SubmitToQueue' has no 'response' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:65: [SubmitToQueue.post] Instance of 'SubmitToQueue' has no 'response' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:68: [SubmitToQueue.post] Instance of 'SubmitToQueue' has no '_int_from_request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/submittoqueue.py:71: [SubmitToQueue.post] Instance of 'SubmitToQueue' has no 'request' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/tool/bot/feeders.py:63: [CommitQueueFeeder.feed] Instance of 'CommitQueueFeeder' has no '_ids_sent_to_server' member [pylint/E1101] [5] Total errors found: 9 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2014-10-02 16:17:55 PDT

No, that's not a good idea. Feeder sends all items to the server every 30 seconds, and now it would be sending them individually, which is not good performance.

Note You need to log in before you can comment on or make changes to this bug.