Bug 137336

Summary: REGRESSION(r173785): Previous page scroll position isn't restored correctly on EFL since r173785
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: XMLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED WORKSFORME    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136917    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
WIP(not include test case yet)
none
WIP none

Gyuyoung Kim
Reported 2014-10-02 01:13:03 PDT
When user back to previous page using backward button on MiniBrowser, previous page's scroll position isn't restored. RenderLayer::scrollRectToVisible() causes this problem because r173785 supports requestScrollPositionUpdate() for EFL port. void RenderLayer::scrollRectToVisible(const LayoutRect& rect, const ScrollAlignment& alignX, const ScrollAlignment& alignY) { ... } else { #if !PLATFORM(IOS) LayoutRect viewRect = frameView.visibleContentRect(); LayoutRect visibleRectRelativeToDocument = viewRect; IntSize documentScrollOffsetRelativeToScrollableAreaOrigin = frameView.documentScrollOffsetRelativeToScrollableAreaOrigin(); visibleRectRelativeToDocument.setLocation(IntPoint(documentScrollOffsetRelativeToScrollableAreaOrigin.width(), documentScrollOffsetRelativeToScrollableAreaOrigin.height())); #else LayoutRect viewRect = frameView.unobscuredContentRect(); LayoutRect visibleRectRelativeToDocument = viewRect; #endif LayoutRect r = getRectToExpose(viewRect, visibleRectRelativeToDocument, rect, alignX, alignY); frameView.setScrollPosition(roundedIntPoint(r.location())); ... }
Attachments
WIP (2.05 KB, patch)
2014-10-07 01:48 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
WIP(not include test case yet) (2.99 KB, patch)
2014-11-02 21:57 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
WIP (5.08 KB, patch)
2014-11-02 23:59 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-10-07 01:48:14 PDT
Created attachment 239402 [details] WIP
Gyuyoung Kim
Comment 2 2014-11-02 21:57:53 PST
Created attachment 240827 [details] WIP(not include test case yet)
Gyuyoung Kim
Comment 3 2014-11-02 23:58:14 PST
It looks this is normal behavior.
Gyuyoung Kim
Comment 4 2014-11-02 23:59:50 PST
Reopening to attach new patch.
Gyuyoung Kim
Comment 5 2014-11-02 23:59:53 PST
Created attachment 240830 [details] WIP
Note You need to log in before you can comment on or make changes to this bug.