Bug 137329 – REGRESSION(r174187): webkitpy failures, and thorton says the patch is wrong (Requested by dethbakin on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Commit Bot]

http://trac.webkit.org/changeset/174187 broke the build:
webkitpy failures, and thorton says the patch is wrong (Requested by dethbakin on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 239076 [details]
ROLLOUT of r174187

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 239076 [details]
ROLLOUT of r174187

Clearing flags on attachment: 239076

Committed r174194: <http://trac.webkit.org/changeset/174194>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

Roger, please try again without the whole bit about WebKit2, which doesn't apply at all on Windows, and with rebaselined webkitpy tests.

[Alexey Proskuryakov]

This rollout broke a webkitpy test: <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/8355/steps/webkitpy-test/logs/stdio>

[Tim Horton]

What? That was the test that was failing that inspired this rollout...

[Daniel Bates]

(In reply to comment #6)
> What? That was the test that was failing that inspired this rollout...

No, this isn't the same test. Prior to the landing of the rollout patch in <http://trac.webkit.org/changeset/174194>, the test PortTestCase.test_default_timeout_ms() was failing (*). At the time of writing the test WinPortTest. test_default_timeout_ms() is failing (see comment #5 for a hyperlink to the stdio log). 

Notice that Brent Fulgham committed <http://trac.webkit.org/changeset/174192> to fix the unit test that failed following <http://trac.webkit.org/changeset/174187>. And <http://trac.webkit.org/changeset/174194> only rolled out <http://trac.webkit.org/changeset/174187>. That is, it did not roll out <http://trac.webkit.org/changeset/174192>. Therefore, test WinPortTest. test_default_timeout_ms(), committed in <http://trac.webkit.org/changeset/174192>, is failing.

(*) <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/8347/steps/webkitpy-test/logs/stdio>

[Daniel Bates]

I'll roll out <http://trac.webkit.org/changeset/174192> per Tim Horton's remark in comment #5 that there are correctness issue with the patch that landed <http://trac.webkit.org/changeset/174187> with regards to WebKit2 on Window.

[Daniel Bates]

Rolled out <http://trac.webkit.org/changeset/174192> in <http://trac.webkit.org/changeset/174198>.

[Tim Horton]

Ah, I see. Nearly but not quite the same.

Thanks for rolling out.

[Roger Fong]

Sorry about that.
I've been in an over zealous rush mode trying to deal with these windows bots and then getting more failures thrown at my face as soon as I think I'm almost finally done being stomped on by them.
I'll be more careful next time.

[Roger Fong]

Oddly, the test failures that inspired me to attempt to make this change in the first place no longer seem to be there...and the bots have already ran than the tests with the rollouts incorporated...so I guess I'll count that as a win...