Summary: | WKDownloadCopyRequest() returns 0 until the download starts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeff Miller <jeffm> | ||||||
Component: | WebKit2 | Assignee: | Jeff Miller <jeffm> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, conrad_shultz, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jeff Miller
2014-10-01 16:25:27 PDT
The actual Radar bug is <rdar://problem/10046884> Created attachment 239119 [details]
Patch
Comment on attachment 239119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239119&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1791 > + ASSERT(m_decidePolicyForResponseRequest); I don't think this is guaranteed to not be null. Comment on attachment 239119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239119&action=review >> Source/WebKit2/UIProcess/WebPageProxy.cpp:1791 >> + ASSERT(m_decidePolicyForResponseRequest); > > I don't think this is guaranteed to not be null. I wasn't 100% sure about this, either. I'll update the patch to pass a reference to ResourceRequest() if it is null. Created attachment 239123 [details]
Patch
Comment on attachment 239123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239123&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1792 > + const ResourceRequest& downloadRequest = m_decidePolicyForResponseRequest ? *m_decidePolicyForResponseRequest : ResourceRequest(); > + DownloadProxy* download = m_process->context().createDownloadProxy(downloadRequest); I'd add a FIXME about ensuring that this ResourceRequest is never empty. Committed r174230: <http://trac.webkit.org/changeset/174230> |