| Summary: | Web Inspector: Replace PDF icon with SVG version | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gomez Garcia <agomez> | ||||||||||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | agomez, cgarcia, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 239018 [details]
Partial patch with the free SVG icon for the GTK port
Ah, yes. I have been meaning to convert this PDF to SVG. It slipped in after our initial conversion. Your patch does not have the SVG. Created attachment 239335 [details]
Updated: Partial patch with the free SVG icon for the GTK port
(In reply to comment #3) > Ah, yes. I have been meaning to convert this PDF to SVG. It slipped in after our initial conversion. > > Your patch does not have the SVG. !!!! Clearly I have to sleep more hours. Thanks for the heads up :) Created attachment 241493 [details]
Patch
Created attachment 241494 [details]
Screenshot
Comment on attachment 241493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241493&action=review r=me > Source/WebInspectorUI/UserInterface/Images/NavigationItemProbes.svg:4 > + <!-- <path d="M 2 11 L 2 4 L 11 4 L 15 7.5 L 11 11 L 2 11 Z"></path> --> Why the comment? Created attachment 241495 [details]
Patch
Comment on attachment 239335 [details] Updated: Partial patch with the free SVG icon for the GTK port Clearing flags on attachment: 239335 Committed r176081: <http://trac.webkit.org/changeset/176081> All reviewed patches have been landed. Closing bug. |
The WebInspector still has the icon: Source/WebInspectorUI/UserInterface/Images/NavigationItemProbes.pdf used at: Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js: WebInspector.DetailsSidebarPanel.call(this, "probe", WebInspector.UIString("Probes"), WebInspector.UIString("Probes"), "Images/NavigationItemProbes.pdf", "6"); PDF icons are not a kind format for other ports like the GTK one so it would be nice to provide a SVG replacement.