Summary: | AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, commit-queue, dbates, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
chris fleizach
2014-09-30 23:07:32 PDT
Created attachment 239006 [details]
patch
Comment on attachment 239006 [details] patch Clearing flags on attachment: 239006 Committed r174330: <http://trac.webkit.org/changeset/174330> All reviewed patches have been landed. Closing bug. Comment on attachment 239006 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239006&action=review > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:194 > + for (NSInteger k = location; k < (location+length); ++k) This broke the iOS build. The comparison here led to the clang warning, "comparison of integers of different signs", because the result of the sub expression location + length is a unsigned data type, but k is a signed data type. And we treat warnings as errors. Comment on attachment 239006 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=239006&action=review >> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:194 >> + for (NSInteger k = location; k < (location+length); ++k) > > This broke the iOS build. The comparison here led to the clang warning, "comparison of integers of different signs", because the result of the sub expression location + length is a unsigned data type, but k is a signed data type. And we treat warnings as errors. strange because I tested on iOS simulator to create this unit test. i'll take another look (In reply to comment #5) > (From update of attachment 239006 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239006&action=review > > >> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:194 > >> + for (NSInteger k = location; k < (location+length); ++k) > > > > This broke the iOS build. The comparison here led to the clang warning, "comparison of integers of different signs", because the result of the sub expression location + length is a unsigned data type, but k is a signed data type. And we treat warnings as errors. > > strange because I tested on iOS simulator to create this unit test. i'll take another look Have you had a chance to take another look? I'm unclear how we are using unsigned, size_t, and NSInteger data types in this code. It seems like we to expect to convert from unsigned to signed to unsigned data types? (why?) Unless you advise otherwise, I plan to roll out <http://trac.webkit.org/changeset/174330> in 10 minutes from now (5:53 PM PST). (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 239006 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=239006&action=review > > > > >> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:194 > > >> + for (NSInteger k = location; k < (location+length); ++k) > > > > > > This broke the iOS build. The comparison here led to the clang warning, "comparison of integers of different signs", because the result of the sub expression location + length is a unsigned data type, but k is a signed data type. And we treat warnings as errors. > > > > strange because I tested on iOS simulator to create this unit test. i'll take another look > > Have you had a chance to take another look? Yes, it takes forever to build after an update. I'm still building > I'm unclear how we are using unsigned, size_t, and NSInteger data types in this code. It seems like we to expect to convert from unsigned to signed to unsigned data types? (why?) I'm cleaning it up > Unless you advise otherwise, I plan to roll out <http://trac.webkit.org/changeset/174330> in 10 minutes from now (5:53 PM PST). I'd urge you to wait for me to resolve this (In reply to comment #7) > [...] > I'd urge you to wait for me to resolve this Will wait. When do you envision landing a fix for this issue? In the next 30 minutes? hour? (In reply to comment #8) > (In reply to comment #7) > > [...] > > I'd urge you to wait for me to resolve this > > Will wait. When do you envision landing a fix for this issue? In the next 30 minutes? hour? 20 mins |