Bug 137284

Summary: Use is<>() / downcast<>() for Event classes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-09-30 19:55:31 PDT 
Use is<>() / downcast<>() for Event classes
Comment 1 Chris Dumez 2014-09-30 20:24:30 PDT 
Created attachment 238989 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-30 20:26:35 PDT 
Attachment 238989 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaDocument.cpp:213:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-09-30 22:23:07 PDT 
Created attachment 238999 [details]
Patch
Comment 4 WebKit Commit Bot 2014-09-30 22:24:45 PDT 
Attachment 238999 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaDocument.cpp:213:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2014-09-30 22:32:25 PDT 
Created attachment 239000 [details]
Patch
Comment 6 Chris Dumez 2014-09-30 22:33:36 PDT 
Created attachment 239001 [details]
Patch
Comment 7 WebKit Commit Bot 2014-09-30 22:34:55 PDT 
Attachment 239001 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaDocument.cpp:213:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Chris Dumez 2014-09-30 22:40:32 PDT 
Created attachment 239002 [details]
Patch
Comment 9 Chris Dumez 2014-09-30 22:41:54 PDT 
Created attachment 239003 [details]
Patch
Comment 10 WebKit Commit Bot 2014-09-30 22:44:55 PDT 
Attachment 239003 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaDocument.cpp:213:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2014-10-01 15:29:24 PDT 
Comment on attachment 239003 [details]
Patch

Clearing flags on attachment: 239003

Committed r174178: <http://trac.webkit.org/changeset/174178>
Comment 12 WebKit Commit Bot 2014-10-01 15:29:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Lucas Forschler 2019-02-06 09:18:51 PST 
Mass move bugs into the DOM component.