Bug 137284

Summary: Use is<>() / downcast<>() for Event classes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137056    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-09-30 19:55:31 PDT
Use is<>() / downcast<>() for Event classes
Attachments
Patch (72.50 KB, patch)
2014-09-30 20:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.55 KB, patch)
2014-09-30 22:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.55 KB, patch)
2014-09-30 22:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.55 KB, patch)
2014-09-30 22:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.56 KB, patch)
2014-09-30 22:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.56 KB, patch)
2014-09-30 22:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-30 20:24:30 PDT
Created attachment 238989 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-30 20:26:35 PDT
Attachment 238989 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaDocument.cpp:213: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2014-09-30 22:23:07 PDT
Created attachment 238999 [details] Patch
WebKit Commit Bot
Comment 4 2014-09-30 22:24:45 PDT
Attachment 238999 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaDocument.cpp:213: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2014-09-30 22:32:25 PDT
Created attachment 239000 [details] Patch
Chris Dumez
Comment 6 2014-09-30 22:33:36 PDT
Created attachment 239001 [details] Patch
WebKit Commit Bot
Comment 7 2014-09-30 22:34:55 PDT
Attachment 239001 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaDocument.cpp:213: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 8 2014-09-30 22:40:32 PDT
Created attachment 239002 [details] Patch
Chris Dumez
Comment 9 2014-09-30 22:41:54 PDT
Created attachment 239003 [details] Patch
WebKit Commit Bot
Comment 10 2014-09-30 22:44:55 PDT
Attachment 239003 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaDocument.cpp:213: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2014-10-01 15:29:24 PDT
Comment on attachment 239003 [details] Patch Clearing flags on attachment: 239003 Committed r174178: <http://trac.webkit.org/changeset/174178>
WebKit Commit Bot
Comment 12 2014-10-01 15:29:29 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 13 2019-02-06 09:18:51 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.