Bug 137267

Summary:

Windows EWS went purple when it failed to build

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	rniwa: review+

Description Alexey Proskuryakov 2014-09-30 14:12:01 PDT

There seems to be something strange about Windows EWS - its bubble doesn't show up at first, and when it failed to build, it went purple instead of orange.

Comment 1 Alexey Proskuryakov 2014-09-30 14:15:32 PDT

I think that I know what it is, it's a bug in Attachment._calculate_queue_positions.

        all_work_items = WorkItems.all().fetch(limit=len(Queue.all()))

This only fetches as many queues as we have configured now - but we've deleted many queues, and they are still in the table. So we fail to fetch work items for some queues.

Comment 2 Alexey Proskuryakov 2014-09-30 14:25:25 PDT

Created attachment 238962 [details]
proposed fix

Comment 3 Alexey Proskuryakov 2014-09-30 14:30:42 PDT

Committed <http://trac.webkit.org/r174124>.