Bug 137262

Summary:

REGRESSION (r173423): [iOS] Sites with EV certificates appear as normal HTTPS sites

Product:

WebKit

Reporter:

mitz

Component:

Page Loading

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, darin, iloveo7, koivisto, ossy

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

https://ssl.apple.com

Attachments:

Description	Flags
Return a CertificateInfo initialized Return a CertificateInfo initialized	koivisto: review+

Description mitz 2014-09-30 13:33:20 PDT

<rdar://problem/18503318>

When navigating to the a website that has an EV certificate, the browser UI doesn’t reflect the EV status of the site. This is happening because after <http://trac.webkit.org/r173423> (and its build fixes), ResourceResponse::platformCertificateInfo() in ResourceResponseCFNet.cpp returns an empty CertificateInfo.

Comment 1 mitz 2014-09-30 13:38:05 PDT

Created attachment 238952 [details]
Return a CertificateInfo initialized Return a CertificateInfo initialized

Comment 2 mitz 2014-10-01 07:31:50 PDT

Fixed in <http://trac.webkit.org/r174156>.

Comment 3 Darin Adler 2014-10-01 08:06:20 PDT

Comment on attachment 238952 [details]
Return a CertificateInfo initialized Return a CertificateInfo initialized

View in context: https://bugs.webkit.org/attachment.cgi?id=238952&action=review

> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:122
> +#endif
>      return CertificateInfo();

#else?

Comment 4 Csaba Osztrogonác 2014-10-01 09:15:15 PDT

(In reply to comment #2)
> Fixed in <http://trac.webkit.org/r174156>.

It broke the Apple Windows build:

     1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory
     1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.

Comment 5 mitz 2014-10-01 09:17:35 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > Fixed in <http://trac.webkit.org/r174156>.
> 
> It broke the Apple Windows build:
> 
>      1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory
>      1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.

Committed a build fix in <http://trac.webkit.org/r174157>.

Comment 6 mitz 2014-10-01 09:17:35 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > Fixed in <http://trac.webkit.org/r174156>.
> 
> It broke the Apple Windows build:
> 
>      1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory
>      1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.

Committed a build fix in <http://trac.webkit.org/r174157>.