EWS doesn't need to show all the bubbles when a patch fails to apply

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

When a patch fails to apply, it's usually failing in the same way on all queues. There is no need to show per-queue bubbles then.

[Alexey Proskuryakov]

Created attachment 238941 [details]
proposed patch

[Ryosuke Niwa]

Comment on attachment 238941 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238941&action=review

> Tools/QueueStatusServer/app.yaml:2
> -version: 174192 # Bugzilla bug ID of last major change
> +version: ap # Bugzilla bug ID of last major change

Revert?

> Tools/QueueStatusServer/handlers/statusbubble.py:194
> -        return (bubbles, show_submit_to_ews)
> +        return (bubbles, show_submit_to_ews, failed_to_apply and not had_output and not show_submit_to_ews)

I would have written this as:

failed_to_apply = any(map(lambda bubble: 'failed_to_apply' in bubble, bubbles)
had_output = all(map(lambda bubble: 'no_output_yet' in bubble, bubbles)
return (bubbles, show_submit_to_ews, failed_to_apply and not had_output)

instead of updating variables in the loop.  It's much easier to understand.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r174114>.