Summary: | [CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, glenn, jfernandez, kling, kondapallykalyan, rego | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60731 | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2014-09-30 08:31:09 PDT
Created attachment 238927 [details]
Patch
Comment on attachment 238927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238927&action=review > Source/WebCore/rendering/RenderGrid.cpp:584 > +void RenderGrid::resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizingDirection direction, GridSizingData& sizingData, GridItemWithSpan& gridItemWithSpan, FilterFunction filterFunction, SizingFunction sizingFunction, AccumulatorGetter trackGetter, AccumulatorGrowFunction trackGrowthFunction, FilterFunction growAboveMaxBreadthFilterFunction) I’m concerned that the extensive use of pointers to member function for these functions is an inefficient design pattern. But this is only a suspicion, not something I am certain about. Committed r174643: <http://trac.webkit.org/changeset/174643> |