Summary: | It should be fun and easy to run every possible JavaScript benchmark from the command line | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | atrick, barraclough, burg, commit-queue, ggaren, juergen, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, ossy, rniwa, saam, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2014-09-29 21:11:08 PDT
Created attachment 238908 [details]
the patch
Comment on attachment 238908 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=238908&action=review In initial testing, it seems to work exactly as expected. I'll be using it more extensively as I test the performance of my upcoming DFG patch and I'll let you know if I run into any problems. Thanks :) > Tools/Scripts/run-jsc-benchmarks:275 > + puts "of the form Conf#<n> will be ascribed to the configuration automatically." Maybe it's worth also adding in that each vm can be given a set of specific CLI options just for that vm, because I didn't know this until you mentioned it to me. Maybe something like: ... or of the string of the form <name>:<options>:<path> or <name>:<path> where <path> is the path to the executable, <options> are the command line options you want passed into this specific vm (i.e, JSC_useJIT=0), and <name> is the name that you would like to give the configuration for the purpose of reporting. (In reply to comment #2) > (From update of attachment 238908 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238908&action=review > > In initial testing, it seems to work exactly as expected. I'll be using it more extensively as I test the performance of my upcoming DFG patch and I'll let you know if I run into any problems. > > Thanks :) > > > Tools/Scripts/run-jsc-benchmarks:275 > > + puts "of the form Conf#<n> will be ascribed to the configuration automatically." > > Maybe it's worth also adding in that each vm can be given a set of specific CLI options just for that vm, because I didn't know this until you mentioned it to me. > > Maybe something like: > ... > or of the string of the form <name>:<options>:<path> or <name>:<path> > where <path> is the path to the executable, <options> are the command line options you want passed into this specific vm (i.e, JSC_useJIT=0), and <name> is the name that you would like to give the configuration for the purpose of reporting. Yup, I added some text about this! Landed in http://trac.webkit.org/changeset/174123 |