Bug 137232

Summary:

Improve Bugzilla status bubbles

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	rniwa: review+
screenshot	none

Description Alexey Proskuryakov 2014-09-29 14:29:29 PDT

These yellow and purple bubbles are not as helpful as they could be.

Comment 1 Alexey Proskuryakov 2014-09-29 14:33:48 PDT

Created attachment 238882 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2014-09-29 14:34:06 PDT

Created attachment 238883 [details]
screenshot

Comment 3 WebKit Commit Bot 2014-09-29 14:36:38 PDT

Attachment 238882 [details] did not pass style-queue:


ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:55:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:54:  whitespace before ']'  [pep8/E202] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:59:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:72:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:81:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:82:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:107:  [StatusBubble._build_message_for_provisional_failure] Undefined variable 'bubble'  [pylint/E0602] [5]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Ryosuke Niwa 2014-09-29 14:45:50 PDT

Comment on attachment 238882 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238882&action=review

Looks good to me.

> Tools/QueueStatusServer/app.yaml:2
> -version: 174015 # Bugzilla bug ID of last major change
> +version: ap # Bugzilla bug ID of last major change

Revert?

Comment 5 Alexey Proskuryakov 2014-09-29 14:55:34 PDT

Committed http://trac.webkit.org/r174087