Bug 137232

Summary: Improve Bugzilla status bubbles
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
rniwa: review+
screenshot none

Alexey Proskuryakov
Reported 2014-09-29 14:29:29 PDT
These yellow and purple bubbles are not as helpful as they could be.
Attachments
proposed patch (14.94 KB, patch)
2014-09-29 14:33 PDT, Alexey Proskuryakov 		rniwa: review+
DetailsFormatted DiffDiff
screenshot (74.38 KB, image/png)
2014-09-29 14:34 PDT, Alexey Proskuryakov 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-09-29 14:33:48 PDT
Created attachment 238882 [details] proposed patch
Alexey Proskuryakov
Comment 2 2014-09-29 14:34:06 PDT
Created attachment 238883 [details] screenshot
WebKit Commit Bot
Comment 3 2014-09-29 14:36:38 PDT
Attachment 238882 [details] did not pass style-queue: ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:55: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:54: whitespace before ']' [pep8/E202] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:59: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:72: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:81: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:82: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/QueueStatusServer/handlers/statusbubble.py:107: [StatusBubble._build_message_for_provisional_failure] Undefined variable 'bubble' [pylint/E0602] [5] Total errors found: 7 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 4 2014-09-29 14:45:50 PDT
Comment on attachment 238882 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=238882&action=review Looks good to me. > Tools/QueueStatusServer/app.yaml:2 > -version: 174015 # Bugzilla bug ID of last major change > +version: ap # Bugzilla bug ID of last major change Revert?
Alexey Proskuryakov
Comment 5 2014-09-29 14:55:34 PDT
Committed http://trac.webkit.org/r174087
Note You need to log in before you can comment on or make changes to this bug.