Summary: | Finish testing and fixing the setting of DOM attributes to JS null | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | DOM | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alice.barraclough, ap, cdumez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 523.x (Safari 3) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2007-05-14 19:19:45 PDT
Created attachment 14570 [details]
patch to fix Core DOM attributes
This patch fixes the remaining attributes in the Core DOM (CharacterData.data, ProcessingInstruction.data, and Attr.value). Patched Attr.value to not throw an exception for null values as this matches the spec and Firefox.
Comment on attachment 14570 [details]
patch to fix Core DOM attributes
How about using dumpAsText for this test?
[ConvertNullStringTo=Null, OldStyleObjC] DOMString substringData(in [IsIndex] unsigned long offset,
- in [IsIndex] unsigned long length)
+ in [IsIndex] unsigned long length)
I'm not a big fan of "high-maintenance" formatting that requires changes to indentation when you rename things or add keywords. Maybe we can reconsider the way we're formatting .idl files at some point.
r=me
Landed first patch in r21489 with Darin's suggestions. Keeping bug open for remaining cases. Created attachment 14575 [details]
Patch to fix CSSOM attributes
Patch changes and tests the CSSOM attributes. I could not test the PageRule one as we never create a PageRule as far as I can tell.
Created attachment 14576 [details]
Patch to fix CanvasRenderingContext2D attributes
Created attachment 14578 [details]
Patch to fix SVG attributes
Last one.
Comment on attachment 14578 [details]
Patch to fix SVG attributes
yay for idl!
Mass moving XML DOM bugs to the "DOM" Component. |