Bug 137212 – [GTK] [EFL] Install TestNetscapePlugin apart from the other libs to avoid scanning all of them on every test.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Revision r174054 <http://trac.webkit.org/r174054> added some error printing that broke 6 Performance Tests <https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/909>, and also caused extra noise when running the API or Layout Tests.


$ Tools/Scripts/run-perf-tests  --platform gtk --release -2 Interactive/window-resize.html

Running Interactive/window-resize.html (1 of 1)
error: Interactive/window-resize.html
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libgtest.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libTestWebKitAPIInjectedBundle.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status
Error scanning plugin /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so, /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitPluginProcess returned 256 exit status

FAILED
Finished: 74.289352 s



The issue seems to affect both the GTK and EFL platforms.

[Carlos Garcia Campos]

This is not exactly a regression, but an existing issue that has been revealed thanks to the error dialogs introduced in r174054. We should not use the same directory for the test plugin and the other libraries, because we end up scanning all the .so in the lib dir for every test.

[Carlos Alberto Lopez Perez]

(In reply to comment #1)
> This is not exactly a regression, but an existing issue that has been revealed thanks to the error dialogs introduced in r174054. We should not use the same directory for the test plugin and the other libraries, because we end up scanning all the .so in the lib dir for every test.

Agreed. Renamed the subject of the bug.

[Carlos Alberto Lopez Perez]

Created attachment 238854 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 238854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238854&action=review

Thanks! Gyuyoung, is this ok for the EFL port?

> Tools/Scripts/webkitpy/port/efl.py:68
> -        env['TEST_RUNNER_PLUGIN_PATH'] = self._build_path('lib')
> +        env['TEST_RUNNER_PLUGIN_PATH'] = self._build_path('lib/plugins')

Nit: this should be self._build_path('lib', 'plugins') so that build_path can use the appropriate dir separator on every platform. Not a big deal, since this is only used in unix, but still.

> Tools/Scripts/webkitpy/port/gtk.py:113
> -        environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('lib')
> +        environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('lib/plugins')

Ditto.

[Carlos Alberto Lopez Perez]

Created attachment 238859 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 238859 [details]
Patch

OK, Gyuyoung, please cq+ this if it it's ok for EFL.

[Gyuyoung Kim]

Comment on attachment 238859 [details]
Patch

LGTM. libTestNetscapePlugin.so is placed at lib/plugins.

[WebKit Commit Bot]

Comment on attachment 238859 [details]
Patch

Clearing flags on attachment: 238859

Committed r174093: <http://trac.webkit.org/changeset/174093>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.